poi: bug 60288: remove defensive copy for internal relationships. Pat…

…ch from Tim Helmstedt.
antony-liu · Mar 13, 2024 · cc1de9a · cc1de9a
1 parent 520b079
commit cc1de9a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/openxml4Net/OPC/OPCPackage.cs b/openxml4Net/OPC/OPCPackage.cs
@@ -1548,7 +1548,7 @@ public bool HasRelationships
          */
         public bool IsRelationshipExists(PackageRelationship rel)
         {
-            foreach (PackageRelationship r in this.Relationships)
+            foreach (PackageRelationship r in relationships)
             {
                 if (r == rel)
                     return true;

diff --git a/openxml4Net/OPC/PackagePart.cs b/openxml4Net/OPC/PackagePart.cs
@@ -473,17 +473,10 @@ public bool HasRelationships
          */
         public bool IsRelationshipExists(PackageRelationship rel)
         {
-            try
+            foreach (PackageRelationship r in _relationships)
             {
-                foreach (PackageRelationship r in this.Relationships)
-                {
-                    if (r == rel)
-                        return true;
-                }
-            }
-            catch (InvalidFormatException)
-            { 
-
+                if (r == rel)
+                    return true;
             }
             return false;
         }