-
-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(linters): Introduce hadolint config file and reorder linters #832
base: master
Are you sure you want to change the base?
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis pull request introduces a new configuration file, .hadolint.yaml, which specifies several Dockerfile linting rules to ignore. In addition, the .pre-commit-config.yaml file has been updated to reorganize linting hooks. The updates include reintroducing the hadolint linter without its previous ignore arguments, streamlining the YAML linter section, cleaning up the JSON5 linter section, and making adjustments (additions and removals) to repository configurations for shfmt and shellcheck. Changes
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (11)
🔇 Additional comments (4)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
- DL4006 # Not related to alpine | ||
- SC1091 # Useless check | ||
- SC2015 # Useless check | ||
- SC3037 # Not related to alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh such comments require reader to google what the check is about. would be great to have a more clear comments (either the brief description of the check, or a more clear rationale to ignore it globally).
I think it's also best to use inline exclusions per each Dockefile rather than exclude checks globally.
# | ||
# Dockerfile | ||
- repo: https://github.com/hadolint/hadolint | ||
rev: v2.12.1-beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be missing some gist of this, but using beta...
Split from #831
Hadolint supports its own config file, and that make able 3rd-party tools that utilize hadolint also known about specified config options, not pre-commit only