Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Set emojis that better represent what happens in GH workflows #819

Merged
merged 4 commits into from
Feb 17, 2025
Merged

chore: Set emojis that better represent what happens in GH workflows #819

merged 4 commits into from
Feb 17, 2025

Conversation

MaxymVlasov
Copy link
Collaborator

No description provided.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Feb 14, 2025 •
edited
Loading

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated visual identifiers in our automation workflows to ensure consistency.
    • Refined branch filtering for automated processes, streamlining internal procedures.

Walkthrough

The changes update the naming conventions in two GitHub Actions workflow files. In the CI/CD workflow file, the workflow name is changed from "🧪" to "∞". Additionally, a new branch ignore pattern for "renovate/" is added, while existing ignore patterns for "maintenance/pip-tools-constraint-lockfiles" and "patchback/backports/" are removed. In the scheduled runs workflow file, the workflow name is updated from "⏳" to "🕔", and the main CI/CD pipeline job name is changed from "🧪 Main CI/CD pipeline" to "∞ Main CI/CD pipeline". The underlying configuration structure and functionality remain unchanged.

Changes

File Path Change Summary
.github/workflows/ci-cd.yml Updated workflow name from 🧪 to ∞, added branch ignore pattern renovate/**, removed ignore patterns for maintenance/pip-tools-constraint-lockfiles and patchback/backports/**. Configuration structure and job definitions remain unchanged.
.github/workflows/scheduled-runs.yml Updated workflow name from ⏳ to 🕔 and job name from 🧪 Main CI/CD pipeline to ∞ Main CI/CD pipeline. Workflow structure, triggers, and job definitions remain unchanged.
📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9edb141 and a9e8453.

📒 Files selected for processing (2)
  • .github/workflows/ci-cd.yml (1 hunks)
  • .github/workflows/scheduled-runs.yml (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • .github/workflows/ci-cd.yml
  • .github/workflows/scheduled-runs.yml
⏰ Context from checks skipped due to timeout of 90000ms (18)
  • GitHub Check: 🧪 Tests / pytest@🐍3.9@windows-2025
  • GitHub Check: 🧪 Tests / pytest@🐍3.9@windows-2025
  • GitHub Check: 🧪 Tests / pytest@🐍3.13@windows-2025
  • GitHub Check: 🧪 Tests / pytest@🐍3.13@windows-2025
  • GitHub Check: 🧪 Tests / pytest@🐍3.12@windows-2025
  • GitHub Check: 🧪 Tests / pytest@🐍3.12@windows-2025
  • GitHub Check: ∞ Main CI/CD pipeline / 🧪 Tests / pytest@🐍3.9@windows-2025
  • GitHub Check: 🧪 Tests / pytest@🐍3.11@windows-2025
  • GitHub Check: 🧪 Tests / pytest@🐍3.11@windows-2025
  • GitHub Check: ∞ Main CI/CD pipeline / 🧪 Tests / pytest@🐍3.9@macos-13
  • GitHub Check: 🧪 Tests / pytest@🐍3.10@windows-2025
  • GitHub Check: 🧪 Tests / pytest@🐍3.10@windows-2025
  • GitHub Check: ∞ Main CI/CD pipeline / 🧪 Tests / pytest@🐍3.13@macos-14
  • GitHub Check: ∞ Main CI/CD pipeline / 🧪 Tests / pytest@🐍3.13@macos-13
  • GitHub Check: 🧹 Linters / pre-commit@🐍3.13@ubuntu-latest
  • GitHub Check: 🧹 Linters / pre-commit@🐍3.13@ubuntu-latest
  • GitHub Check: ∞ Main CI/CD pipeline / 🧪 Tests / pytest@🐍3.11@windows-2025
  • GitHub Check: ∞ Main CI/CD pipeline / 🧪 Tests / pytest@🐍3.12@macos-14
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov Codecov
Copy link

codecov bot commented Feb 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.38%. Comparing base (1e54f11) to head (a9e8453).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #819   +/-   ##
=======================================
  Coverage   96.38%   96.38%           
=======================================
  Files          10       10           
  Lines         249      249           
  Branches        7        7           
=======================================
  Hits          240      240           
  Misses          9        9
Flag Coverage Δ
CI-GHA 96.38% <ø> (ø)
MyPy 91.05% <ø> (ø)
OS-Linux 96.38% <ø> (ø)
OS-Windows 100.00% <ø> (ø)
OS-macOS 100.00% <ø> (ø)
Py-3.10.11 100.00% <ø> (ø)
Py-3.10.16 100.00% <ø> (ø)
Py-3.11.11 100.00% <ø> (ø)
Py-3.11.9 100.00% <ø> (ø)
Py-3.12.8 100.00% <ø> (ø)
Py-3.12.9 100.00% <ø> (ø)
Py-3.13.1 100.00% <ø> (+3.61%) ⬆️
Py-3.13.2 96.38% <ø> (ø)
Py-3.9.13 100.00% <ø> (ø)
Py-3.9.21 100.00% <ø> (ø)
VM-macos-13 100.00% <ø> (ø)
VM-macos-14 100.00% <ø> (ø)
VM-ubuntu-24.04 100.00% <ø> (ø)
VM-ubuntu-latest 91.05% <ø> (ø)
VM-windows-2025 100.00% <ø> (ø)
pytest 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yermulnik
yermulnik approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@yermulnik yermulnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely happy with the purple'ish background color on CI/CD sign emoji 🤣

@MaxymVlasov
Copy link
Collaborator Author

It's blue on Firefox on Ubuntu

But I see it as purple on Android -__-

@MaxymVlasov
Copy link
Collaborator Author

Like this one for twitter
https://emojipedia.org/infinity#designs

Need to check is there a way to force specific style

@MaxymVlasov
Copy link
Collaborator Author

We can try:

  • ∞
  • ᨖ
  • ♾
  • ᪲᪲᪲

Just need to test how it looks like on different OS and browsers

@yermulnik
Copy link
Collaborator

Chrome 🤮
image
FF 😍
image

Just need to test how it looks like on different OS and browsers

The very last looks broken on both browsers for me:
image

The 1st and 2nd look ok =)

@MaxymVlasov
Copy link
Collaborator Author

FF on Android
Screenshot_20250215-020127

GH mobile (probably chrome-based)
Screenshot_20250215-020344

@MaxymVlasov MaxymVlasov merged commit c613da7 into master Feb 17, 2025
92 checks passed
@MaxymVlasov MaxymVlasov deleted the better_emojis branch February 17, 2025 19:28
@antonbabenko
Copy link
Owner

This PR is included in version 1.97.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yermulnik yermulnik Awaiting requested review from yermulnik yermulnik is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxymVlasov @yermulnik @antonbabenko