ci: Utilize native arm64 linux runners #784
Conversation
This should speed up docker image build process during tests and wipe out one of dependencies
|
Here we go again... Looks like I need to fork and add arm support to https://github.com/plexsystems/container-structure-test-action/ Binary already exist, also here docker image. Whould be nice to use it Or, maybe I can use it directly, without action |
| @@ -16,9 +16,6 @@ jobs: | |||
| steps: | |||
| - name: Checkout code | |||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | |||
| - name: Set up QEMU | |||
| # yamllint disable-line rule:line-length | |||
| uses: docker/setup-qemu-action@53851d14592bedcffcf25ea515637cff71ef929a # v3.3.0 | |||
There was a problem hiding this comment.
Double-checked - it works without it
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #784 +/- ##
=======================================
Coverage 96.38% 96.38%
=======================================
Files 10 10
Lines 249 249
Branches 7 7
=======================================
Hits 240 240
Misses 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
|
||
| - name: Dive - check image for waste files | ||
| if: steps.changed-files-specific.outputs.any_changed == 'true' | ||
| # yamllint disable-line rule:line-length | ||
| uses: MaxymVlasov/dive-action@379af3fc636888ada5899c997e8b52db6ad45023 # v1.0.1 | ||
| uses: MaxymVlasov/dive-action@b6a02b38f0f309e8817199658eab090d4f0f93ce # v1.1.0 |
There was a problem hiding this comment.
Lol, I spent whole day on it 🤪
3 releases, 1 for external collaborator PRs, 1 to polish and make-up-to date f*ng node_modules/ GHA on TypeScript, and 1 to actually add ARM support (hopefully there is a fork of dive itself which added docker ARM builds)
| - name: Run structure tests | ||
| if: steps.changed-files-specific.outputs.any_changed == 'true' | ||
| # yamllint disable-line rule:line-length | ||
| uses: plexsystems/container-structure-test-action@c0a028aa96e8e82ae35be556040340cbb3e280ca # v0.3.0 |
There was a problem hiding this comment.
It also has issues with MacOS, which blocks #636, so I replaced it with binary, as I don't want to write my own GHA from scratch for this
|
This PR is included in version 1.97.1 🎉 |
Description of your changes
This should speed up docker image build process during tests and wipe out one of dependencies