Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make package directory and simplify package setup #92

Closed
wants to merge 2 commits into from

Conversation

jmabry
Copy link

@jmabry jmabry commented Jun 12, 2018

Closes #91

Tested successfully with

conda create -n pyaf3
conda activate pyaf3
conda install pip
pip install scipy pandas sklearn matplotlib pydot dill pathos sqlalchemy
pip install -e .
python tests/hierarchical/test_grouped.py

setup(name='pyaf',
version='1.0',
description='Python Automatic Forecasting',
author='Antoine CARME',
author_email='antoine.carme@laposte.net',
url='https://github.com/antoinecarme/pyaf',
license='BSD 3-clause',
packages=['pyaf' , 'pyaf.TS' , 'pyaf.CodeGen' , 'pyaf.Bench'],
packages=['pyaf'],
Copy link
Author

@jmabry jmabry Jun 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antoinecarme Please take a look at the proposed changes to setup.py right here. The significant change is that we are now only identifying a single "package" and adding __init__.py files to the package modules (TS, CodeGen, and Bench).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no longer any need to copy files into the sub package directories at setup time. I think this a more standard approach for python packaging

@antoinecarme
Copy link
Owner

Did you test this outside conda ?

@jmabry jmabry closed this Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Editable Install Doesn't Work
2 participants