Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Fix for #4008 -- add testing of TypeScript target back #4010

Merged
merged 2 commits into from
Mar 15, 2024
Merged

[build] Fix for #4008 -- add testing of TypeScript target back #4010

merged 2 commits into from
Mar 15, 2024

Conversation

kaby76
Copy link
Contributor

@kaby76 kaby76 commented Mar 12, 2024 •
edited
Loading

Fixes #4008.

  • Add TypeScript testing.
  • Add "Antlr4ng" TypeScript for testing that target in the future, as it is superior to Antlr 4.13.1. For example, inclusion of base classes is not possible with 4.13.1. And, it is not clear whether we will have another release of Antlr4, which would fix the issue. Implement consistent file extensions for Typescript imports antlr4#4492
  • Remove testing of grammars that have TypeScript base class code as 4.13.1 does not work with these grammars.

kaby76 added 2 commits March 12, 2024 07:47
@kaby76
Fix for antlr#4008
10c8ca3 
Add TypeScript testing. Add "Antlr4ng" TypeScript for future testing , as it is superior to Antlr 4.13.1. Remove grammars that have TypeScript base class code as 4.13.1 does not work with these grammars.
@kaby76
Fix sql/plsql TypeScript target -- does not work for 4.13.1.
0397cef
@kaby76 kaby76 changed the title [build] Fix for #4008 -- add testing of TypeScript back [build] Fix for #4008 -- add testing of TypeScript target back Mar 13, 2024
@teverett
Copy link
Member

@kaby76 thanks!

@teverett teverett merged commit 3b26af5 into antlr:master Mar 15, 2024
24 checks passed
@kaby76 kaby76 mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
infrastructure target:typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[build] Re-add TypeScript testing
3 participants
@kaby76 @teverett @KvanTTT