Replace experimental dependency on golang.org/x/exp #4294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TristonianJones <tswadell@google.com>
…stent files Signed-off-by: TristonianJones <tswadell@google.com>
eb1cb27 to
ce32df8
Compare
|
I have already done this and used explicit functions. But that didn’t make
it in to .13 because I forgot. It is in a separate performance branch that
I have not put in as a PR yet.
…On Wed, May 31, 2023 at 13:48 Tristan Swadell ***@***.***> wrote:
The golang.org/x/exp module does not make any guarantees about API or
functionality stability; however, the functions being used slices.Equal
<https://pkg.go.dev/golang.org/x/exp/slices#Equal> and slices.EqualFunc
<https://pkg.go.dev/golang.org/x/exp/slices#EqualFunc> are relatively
straight-forward. Equivalent functionality has been reproduced in the
contexts where these functions were used.
This change means that ANTLR will no longer have any go.mod dependencies
which might otherwise affect minimum version selection (MVS) on an unstable
API surface.
------------------------------
You can view, comment on, or merge this pull request online at:
#4294
Commit Summary
- 628602d
<628602d>
Update dotnet to the latest version (6 -> 7)
- e26ce94
<e26ce94>
Remove the golang.org/x/exp dependency
File Changes
(6 files <https://github.com/antlr/antlr4/pull/4294/files>)
- *M* .github/workflows/hosted.yml
<https://github.com/antlr/antlr4/pull/4294/files#diff-9118fac9b0d6d13b2be6da445b4bef665ac0d221ec0ac35fe27e7ff050f6d55e>
(2)
- *M*
runtime-testsuite/resources/org/antlr/v4/test/runtime/helpers/Antlr4.Test.csproj.stg
<https://github.com/antlr/antlr4/pull/4294/files#diff-f3e8f500704917ba4da9b6f2b1cb7a6420c2f948d145af2739742382ef7f694f>
(2)
- *M* runtime/Go/antlr/v4/go.mod
<https://github.com/antlr/antlr4/pull/4294/files#diff-06501a4d757bc44321a0f16a047be8b185f19c71dfd828334aacbbc97b654c4e>
(2)
- *M* runtime/Go/antlr/v4/go.sum
<https://github.com/antlr/antlr4/pull/4294/files#diff-6b57bdfd9b3f7d325d3fcf5a2404863a9ff7ebe92a6b84c9d269e1d5dd7dd828>
(4)
- *M* runtime/Go/antlr/v4/lexer_action_executor.go
<https://github.com/antlr/antlr4/pull/4294/files#diff-f3d354f34ec4352a3ec7eaa2cbe428050d0fe3da16f36a5ad457b62864e76f33>
(12)
- *M* runtime/Go/antlr/v4/prediction_context.go
<https://github.com/antlr/antlr4/pull/4294/files#diff-9b169f021623581756abb3a7e6163ac9cda1c7ef73c1a29b3ebe57bcb5fcefc1>
(70)
Patch Links:
- https://github.com/antlr/antlr4/pull/4294.patch
- https://github.com/antlr/antlr4/pull/4294.diff
—
Reply to this email directly, view it on GitHub
<#4294>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ7TMGEW2VPP2PIWXQ4PGTXI3LSLANCNFSM6AAAAAAYU54T6U>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
@jimidle Any objections to submitting this narrowly scoped PR? Or, rather do you have an ETA for when you expect to produce a PR? Thanks, -Tristan |
|
Well, let me see what you have done vs what I have done. I will look today.
When I merge my PR it will likely then have a merge conflict etc. I will
get back to you. Thanks for your effort.
It’s worth raising an issue before doing work, so we all know it’s stuff we
need.
…On Thu, Jun 1, 2023 at 00:21 Tristan Swadell ***@***.***> wrote:
@jimidle <https://github.com/jimidle> Any objections to submitting this
narrowly scoped PR? Or, rather do you have an ETA for when you expect to
produce a PR?
Thanks,
-Tristan
—
Reply to this email directly, view it on GitHub
<#4294 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ7TMHY32VU7ZJWKZCX7ODXI5VYNANCNFSM6AAAAAAYU54T6U>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
This would help me out as well. How can I help to get this small change merged? |
|
I have some time this week to bring in such changes. In fact I already did this in my own branch |
|
Sorry for the delay in bringing in these minor changes, but I have been a little busy. |
|
I did not bring that in to 4.13.1 as I have been too busy to get to it. If you wish to resubmit this, after rebase then I can bring this in. I would like to keep slices.Sort though. It is still in the exp package but it is obviously baked now. I do not know when that will make it out of exp but I am sure it will. I know the interface is not guaranteed, but I highly doubt that it will change. |
|
Go 1.21 added slices.Sort to the stdlib; https://go.dev/doc/go1.21#slices |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
golang.org/x/expmodule does not make any guarantees about API or functionality stability; however, the functions being usedslices.Equalandslices.EqualFuncare relatively straight-forward. Equivalent functionality has been reproduced in the contexts where these functions were used.This change means that ANTLR will no longer have any go.mod dependencies which might otherwise affect minimum version selection (MVS) on an unstable API surface.