Windows specific fixes #3678
Merged
Windows specific fixes #3678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcking Can you take a look at this? |
|
Hi @hs-apotell could you take a look at the conflict here? Or maybe @QuantamHD? I have refreshed my C++ knowledge but the build stuff is magic! |
* Set the MSVC runtime library configuration AFTER the option to select CRT is set. * Add the post build steps only if building tests Signed-off-by: HS <hs@apotell.com>
Signed-off-by: HS <hs@apotell.com>
|
@parrt Resolved. P.S. Looks like the Mac OSX swift tests are failing for different reason. |
|
thanks! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows specific fixes
Signed-off-by: HS hs@apotell.com