Reduce the responsibility of ResultProtocol.
#235
Merged
+26
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdiep
requested changes
May 31, 2017
| @@ -1,14 +1,14 @@ | |||
| // Copyright (c) 2015 Rob Rix. All rights reserved. | |||
|
|
|||
| /// An enum representing either a failure with an explanatory error, or a success with a result value. | |||
| public enum Result<T, Error: Swift.Error>: ResultProtocol, CustomStringConvertible, CustomDebugStringConvertible { | |||
| case success(T) | |||
| public enum Result<Value, Error: Swift.Error>: ResultProtocol, CustomStringConvertible, CustomDebugStringConvertible { | |||
There was a problem hiding this comment.
This is a separate, breaking change. We should probably do this separately?
There was a problem hiding this comment.
Since we're all for this change, so I'm okay with just doing it here.
Result/ResultProtocol.swift
Outdated
| @@ -1,34 +1,14 @@ | |||
| // Copyright (c) 2015 Rob Rix. All rights reserved. | |||
|
|
|||
| /// A type that can represent either failure with an error or success with a result value. | |||
| // A protocol that can be used to constrain associated types as `Result`. | |||
There was a problem hiding this comment.
This should have 3 /s so it shows up in Xcode's documentation viewer.
|
I'd definitely love to have @ikesyo review this. He has a much better understanding of the consequences of this than I do. |
mdiep
approved these changes
Jun 9, 2017
|
🤘 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to signal and producer operators in ReactiveSwift, method and computed properties are now moved to the concrete type.
ResultProtocolnow requires only aResultProtocol.resultrequirement which materializesself.Caveat: Automatic migration is impossible, but manual migration is not hard (copy & pasting
.result).