Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Equatable conformance to NoError #200

Merged
merged 1 commit into from
Nov 27, 2016

Conversation

natestedman
Copy link
Contributor

To allow use with functions dependent on Equatable conformance, i.e.

let foo = Result<Int, NoError>(value: 10)
let bar = Result<Int, NoError>(value: 10)

foo == bar

@mdiep
Copy link
Contributor

mdiep commented Nov 25, 2016

This seems fine to me. Anyone have a reason why we shouldn't?

Copy link
Contributor

@NachoSoto NachoSoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that there might be philosophical/mathematical reasons why this doesn't make sense, but I think in practice it does.

@mdiep mdiep merged commit 308215b into antitypical:swift2.x Nov 27, 2016
@ikesyo
Copy link
Member

ikesyo commented Nov 28, 2016

Is this intentionally targeted to swift2.x branch, not master (Swift 3) ?

@mdiep
Copy link
Contributor

mdiep commented Nov 28, 2016

I'm embarrassed to say that I didn't notice which branch it was targeting. 😞

ikesyo added a commit that referenced this pull request Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants