Add type-erased AnyError for generic contexts
#198
Conversation
In Swift 3, `Error` should be widely used instead of `NSError`. So the type should be useful to wrap arbitrary `Error` instances for uses in generic contexts.
9abb873 to
a7d0cdc
Compare
| public func materialize<T>(_ f: () throws -> T) -> Result<T, NSError> { | ||
| return materialize(try f()) | ||
| } | ||
|
|
||
| @available(*, deprecated, message: "Use the overroad which returns `Result<T, AnyError>` instead") |
There was a problem hiding this comment.
I'm not confident whether those should be deprecated or not.
|
|
||
| public static func ==(lhs: AnyError, rhs: AnyError) -> Bool { | ||
| return lhs.error._code == rhs.error._code | ||
| && lhs.error._domain == rhs.error._domain |
There was a problem hiding this comment.
_domain should be compared before _code.
There was a problem hiding this comment.
Sorry, I withdraw my comment.
There was a problem hiding this comment.
Quick question: Are _domain and _code allowed to use?
There was a problem hiding this comment.
Are
_domainand_codeallowed to use?
I'm not confident. It should be okay to remove Equatable conformance (in that case use them for testing purpose only).
There was a problem hiding this comment.
I'm not confident. It should be okay to remove Equatable conformance (in that case use them for testing purpose only).
+1. I also think removing Equatable is safer to ship 
| public let error: Swift.Error | ||
|
|
||
| public init(_ error: Swift.Error) { | ||
| self.error = error |
There was a problem hiding this comment.
Don't we need to check if error is AnyError?
|
Any other thoughts? @antitypical/result |
| @@ -169,6 +183,29 @@ extension NSError: ErrorProtocolConvertible { | |||
| /// contains an `Int`eger and is guaranteed never to be a `failure`. | |||
| public enum NoError: Swift.Error { } | |||
|
|
|||
| /// A type-erased error which wraps an arbitrary error instance. This should be | |||
| /// useful for generic contexts. | |||
| public struct AnyError: Swift.Error, ErrorProtocolConvertible, CustomStringConvertible { | |||
There was a problem hiding this comment.
Maybe separate the conformances from the type?
| public let error: Swift.Error | ||
|
|
||
| public init(_ error: Swift.Error) { | ||
| if let anyError = error as? AnyError { |
|
Thanks for the review comments! I'll merge this once CI passes, then I'd like to cut a new release with #201. |
In Swift 3,
Errorshould be widely used instead ofNSError. So the type should be useful to wrap arbitraryErrorinstances for uses in generic contexts.This is an additive, non-breaking change.