-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Swift Package Manager #126
Add support for Swift Package Manager #126
Conversation
😍😍😍😍 |
@@ -191,7 +191,8 @@ | |||
D454806E1A9572F5009D7229 /* ResultTests.swift */, | |||
D454806C1A9572F5009D7229 /* Supporting Files */, | |||
); | |||
path = ResultTests; | |||
name = ResultTests; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can rename the group too if it makes things easier. I’ve no preference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m a little surprised we don’t have to do the same thing with the sources as well.
Thank you for the PR! |
Could this get merged? |
Needs a merge from master, to begin with. |
If this pull request is merged into the Swift build tool: swiftlang/swift-package-manager#16 This commit can be reverted.
51830c1
to
6b6d86b
Compare
Rebased. |
Thanks! |
Add support for Swift Package Manager
This adds support for the Swift Package Manager. Due to swiftlang/swift-package-manager#16, I had to rename the
ResultTests
directory toTests
. Building and testing in Xcode and withcarthage
still works correctly.You can test it with this
Package.swift
file:I had to tag an additional release on my fork to try it out, as I don't believe that the Swift Package Manager currently supports arbitrary branches or commit SHAs like
carthage
does.