Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Swift Package Manager #126

Merged
merged 3 commits into from
Dec 22, 2015

Conversation

natestedman
Copy link
Contributor

This adds support for the Swift Package Manager. Due to swiftlang/swift-package-manager#16, I had to rename the ResultTests directory to Tests. Building and testing in Xcode and with carthage still works correctly.

You can test it with this Package.swift file:

import PackageDescription

let package = Package(
    name: "Testing",
    dependencies: [
        .Package(url: "https://github.com/natestedman/Result.git", majorVersion: 1, minor: 1)
    ]
)
$ /Library/Developer/Toolchains/swift-2.2-SNAPSHOT-2015-12-01-a.xctoolchain/usr/bin/swift build
Compiling Swift Module 'Result' (2 sources)
Linking Library:  .build/debug/Result.a

I had to tag an additional release on my fork to try it out, as I don't believe that the Swift Package Manager currently supports arbitrary branches or commit SHAs like carthage does.

@NachoSoto
Copy link
Contributor

😍😍😍😍

@@ -191,7 +191,8 @@
D454806E1A9572F5009D7229 /* ResultTests.swift */,
D454806C1A9572F5009D7229 /* Supporting Files */,
);
path = ResultTests;
name = ResultTests;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can rename the group too if it makes things easier. I’ve no preference.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m a little surprised we don’t have to do the same thing with the sources as well.

@robrix
Copy link
Contributor

robrix commented Dec 4, 2015

Thank you for the PR!

@swizzlr
Copy link

swizzlr commented Dec 22, 2015

Could this get merged?

@robrix
Copy link
Contributor

robrix commented Dec 22, 2015

Needs a merge from master, to begin with.

@natestedman natestedman force-pushed the feature/swift-package-manager branch from 51830c1 to 6b6d86b Compare December 22, 2015 15:34
@natestedman
Copy link
Contributor Author

Rebased.

@robrix
Copy link
Contributor

robrix commented Dec 22, 2015

Thanks!

robrix added a commit that referenced this pull request Dec 22, 2015
@robrix robrix merged commit 1a2c456 into antitypical:master Dec 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants