feat: validate rule meta.schema
#9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
approved these changes
Dec 5, 2024
tschaub
reviewed
Dec 7, 2024
| // Forked from https://github.com/eslint/eslint/blob/7fe4114be2e714506fd406ea4474430ea3de0f93/lib/config/flat-config-helpers.js and https://github.com/eslint/eslint/blob/7fe4114be2e714506fd406ea4474430ea3de0f93/lib/shared/ajv.js | ||
|
|
||
| import Ajv from 'ajv' | ||
| import metaSchema from 'ajv/lib/refs/json-schema-draft-04.json' |
There was a problem hiding this comment.
When I try to run tests with this, I get the following:
TypeError: Module "file:///path/to/node_modules/ajv/lib/refs/json-schema-draft-04.json" needs an import attribute of "type: json"
I'll try to put together a minimal reproducible case, but I'm curious if anybody else has worked around the same.
There was a problem hiding this comment.
In the meantime, downgrading to eslint-vitest-rule-tester@v0.6.1 solves the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
meta.schemacheck to test-runner. Like ESLint test-runner does.Linked Issues
eslint-stylistic/eslint-stylistic#616
Additional context
taze is added to exclude ajv version bumpping to keep it the same as ESLint uses.