Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also add BOOST_UNORDERED_DISABLE_NEON for users of libtester #532

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

spoonincode
Copy link
Member

Follow up to #519. I think we probably need to do this or run the risk of ODR violations (on ARM) if something else uses boost::unordered as part of the external test compilation. It's also possible it's already a ODR violation as-is since apply_context.hpp -- exposed as public libtester interface -- does a #include <boost/unordered/unordered_flat_map.hpp>. (I admit to not looking at unordered's impl yet to know if this ODR violation theory is possible or not, but seems like this is right thing to do -- it's possible original reporter in #517 will need it anyways to compile their external tests)

@spoonincode spoonincode merged commit 7bd7153 into main Aug 13, 2024
36 checks passed
@spoonincode spoonincode deleted the BUDN_libtester branch August 13, 2024 22:11
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: INTERNALS
summary: Add compile option BOOST_UNORDERED_DISABLE_NEON to better support arm.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants