Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable NEON on arm in boost unordered. #519

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Disable NEON on arm in boost unordered. #519

merged 3 commits into from
Aug 12, 2024

Conversation

greg7mdp
Copy link
Contributor

Disable NEON on arm in boost unordered because of conflicting declaration for float16_t in softfloat library.

Resolves #517.

@greg7mdp greg7mdp requested review from heifner and linh2931 August 12, 2024 12:32
@greg7mdp
Copy link
Contributor Author

greg7mdp commented Aug 12, 2024

Will likely be needed in this PR as well.

@spoonincode
Copy link
Member

Seems like we should bring this up globally, like for example,

spring/CMakeLists.txt

Lines 178 to 180 in b58cbbc

# many tests require handling of signals themselves and even when they don't we'd like for them to generate a core dump, this
# is effectively --catch_system_errors=no broadly across all tests
add_compile_definitions(BOOST_TEST_DEFAULTS_TO_CORE_DUMP)

Otherwise it's just not practical for everyone to remember to add that define when they include that file

@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: INTERNALS
summary: Disable NEON due to conflict in softfloat library which created problems on ARM builds.
Note:end

@greg7mdp greg7mdp merged commit 10295c4 into main Aug 12, 2024
36 checks passed
@greg7mdp greg7mdp deleted the gh_517 branch August 12, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build unit_tests on ARM: conflicting declaration for float types
4 participants