Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Update test to try a few times for a full set of voting finalizers #518

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Aug 12, 2024

Test for finalizers voting strictly required votes from all finalizers on the inspected block. It is possible to not always get all votes in time. Modify the test to look at a few blocks for the finalizers before indicating failure.

Resolves #511

@heifner heifner requested review from linh2931 and greg7mdp August 12, 2024 12:12
@heifner heifner added the OCI Work exclusive to OCI team label Aug 12, 2024
@heifner heifner merged commit b58cbbc into main Aug 12, 2024
36 checks passed
@heifner heifner deleted the GH-511-test branch August 12, 2024 13:56
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: TEST
summary: Update test to be less strict, will examine a few blocks before indicating failure.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: separate_prod_fin_test
4 participants