Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure: separate_prod_fin_test #511

Closed
heifner opened this issue Aug 8, 2024 · 0 comments · Fixed by #518
Closed

Test failure: separate_prod_fin_test #511

heifner opened this issue Aug 8, 2024 · 0 comments · Fixed by #518
Assignees
Labels
👍 lgtm OCI Work exclusive to OCI team test-instability tag issues for flaky tests, high priority to address

Comments

@heifner
Copy link
Member

heifner commented Aug 8, 2024

https://github.com/AntelopeIO/spring/actions/runs/10309295866/job/28539031748

2024-08-08T21:03:57.088340 {'qc': {'block_num': 151, 'active_policy_sig': {'strong_votes': '01111', 'sig': 'SIG_BLS_0VtwjvKLWTQyS-8nrdTQLghIue8POyp4kBHZRjLoooiflZryYJ6GvvQNEMhTCLAU3-LT88e9j8f1qsp7Q7kmhYN1F34LsLNmSJibug06utVppp9dxmqbGRM9USvEKBAAbcUf0sZ9FfMrN1HYWAz3cyGsAExM8mSAY3FhULV4w2PEx-CjEizUp6to6hU1BM8QGlxFU_VRNqrZJEchJKdEyUbVGlSAfipBX3ueJjFr_BKgfO_LJEV7eSQ4IjXza40UNFdBdg'}}}
2024-08-08T21:03:57.088536  Test failed.
2024-08-08T21:03:57.088734   Cluster shutting down.
Traceback (most recent call last):
  File "/__w/spring/spring/build/tests/separate_prod_fin_test.py", line 77, in <module>
    assert qc_ext["qc"]["active_policy_sig"]["strong_votes"] == "11111", 'Not all finalizers voted'
AssertionError: Not all finalizers voted

The node didn't get one of the votes in time. Seems like the test is too fragile. Maybe the test should check a few blocks and verify at least one of them has all strong votes.

@heifner heifner added the test-instability tag issues for flaky tests, high priority to address label Aug 8, 2024
@arhag arhag added 👍 lgtm and removed triage labels Aug 9, 2024
@arhag arhag added this to the Spring v1.0.0 milestone Aug 9, 2024
@heifner heifner self-assigned this Aug 11, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Aug 11, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Aug 11, 2024
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Aug 12, 2024
heifner added a commit that referenced this issue Aug 12, 2024
Test: Update test to try a few times for a full set of voting finalizers
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 lgtm OCI Work exclusive to OCI team test-instability tag issues for flaky tests, high priority to address
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants