Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0-beta3 -> main] clear state history's finality log if savanna transition is forked out #331

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

spoonincode
Copy link
Member

main merge of #301:

Avoid state history finality log failure and node shutdown if savanna transition is forked out. Resolves #289. This is a fairly simple change that erases all finality data log files and reopens a fresh head log when savanna finality data is removed (which can only happen upon the transition being forked out).

An even simpler alternative would be to always write the std::optional<finality_data_t> out, which we could do instead, but that puts a little more burden on consumers.

@spoonincode spoonincode merged commit 644d190 into main Jun 27, 2024
36 checks passed
@spoonincode spoonincode deleted the clear_finality_log branch June 27, 2024 23:14
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: INTERNALS
summary: Clear out the state history log when Savanna transition is forked out.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants