[1.0-beta3] clear state history's finality log if savanna transition is forked out #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
approved these changes
Jun 16, 2024
heifner
approved these changes
Jun 17, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid state history finality log failure and node shutdown if savanna transition is forked out. Resolves #289. This is a fairly simple change that erases all finality data log files and reopens a fresh head log when savanna finality data is removed (which can only happen upon the transition being forked out).
An even simpler alternative would be to always write the
std::optional<finality_data_t>out, which we could do instead, but that puts a little more burden on consumers.