fix: Sender with `actions` missing SpeechButton #549

zombieJ · 2025-02-21T03:06:23Z

修复 Sender 的 actions 缺少 SpeechButton 组件的问题。

Summary by CodeRabbit

新特性
- 在发送界面中新增了语音按钮，与现有的操作按钮一起显示，方便用户使用语音输入功能。
- 语音功能在特定条件下启用，增强了交互体验，用户可在消息发送过程中选择语音输入。

coderabbitai · 2025-02-21T03:06:29Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)

components/sender/__tests__/__snapshots__/demo-extend.test.ts.snap is excluded by !**/*.snap
components/sender/__tests__/__snapshots__/demo.test.ts.snap is excluded by !**/*.snap

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

本次改动在 sender 模块中新增了 SpeechButton 组件，扩展了两个主要组件。在 Demo 组件中，SpeechButton 被加入到原有的 SendButton、LoadingButton 和 ClearButton 之间，并在 Space 组件内渲染；在 ForwardSender 组件中，ActionsRender 类型更新包含了 SpeechButton，并在 allowSpeech 为 true 时条件渲染该按钮。整个改动仅涉及 UI 组件的集成，控制流与状态管理未做改动。

Changes

File(s)	Change Summary
components/sender/demo/…/actions.tsx	在 Demo 组件中新增 `SpeechButton`，与其他按钮（SendButton、LoadingButton、ClearButton）一起渲染。
components/sender/…/index.tsx	更新 ActionsRender 类型，加入 `SpeechButton`；在 ForwardSender 中根据 `allowSpeech` 条件渲染该按钮。

Sequence Diagram(s)

sequenceDiagram
    participant User as 用户
    participant Demo as Demo组件
    participant ActionPanel as 按钮区容器
    participant SpeechButton as SpeechButton组件
    participant Sender as ForwardSender组件

    User->>Demo: 加载并展示动作面板
    Demo->>ActionPanel: 传递按钮组件（Send, Loading, Clear, Speech）
    ActionPanel->>SpeechButton: 渲染 SpeechButton（当允许语音时）
    User->>SpeechButton: 点击 Speech 按钮
    SpeechButton->>Sender: 触发语音输入逻辑
    Sender-->>SpeechButton: 返回处理结果

Poem

我是草地上跳跃的小兔子，
看着新按钮闪耀着诗意的光辉，
语音随风，心声随影，
一按之间梦想传递无限可能，
欢庆代码更新，跃动心中欢喜！

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-02-21T03:06:32Z

codecov · 2025-02-21T03:07:24Z

Bundle Report

Bundle size has no change ✅

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

components/sender/index.tsx (1)
346-348: 语音功能状态管理完善

语音按钮的状态管理逻辑完整，包括：

禁用状态控制

录音状态同步

触发回调处理

建议添加错误处理逻辑。
 onSpeech: () => triggerSpeech(false),
 onSpeechDisabled: !speechPermission,
 speechRecording,
+onSpeechError: (error: Error) => {
+  console.error('Speech recognition error:', error);
+  // 可以在这里添加用户提示
+},

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ba911ce and 601347a.

⛔ Files ignored due to path filters (2)

components/sender/__tests__/__snapshots__/demo-extend.test.ts.snap is excluded by !**/*.snap
components/sender/__tests__/__snapshots__/demo.test.ts.snap is excluded by !**/*.snap

📒 Files selected for processing (2)

components/sender/demo/actions.tsx (1 hunks)
components/sender/index.tsx (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (6)

GitHub Check: test / react component workflow
GitHub Check: build preview
GitHub Check: size
GitHub Check: Analyze (javascript-typescript)
GitHub Check: test / react component workflow
GitHub Check: Cloudflare Pages

🔇 Additional comments (4)

components/sender/demo/actions.tsx (1)

38-38: 新增语音按钮组件集成

SpeechButton 组件已正确集成到操作按钮中。按钮布局合理，位于清除按钮和发送按钮之间。

Also applies to: 46-46

components/sender/index.tsx (3)

36-36: 类型定义更新完善

ActionsRender 接口中已正确添加 SpeechButton 组件类型定义。

261-264: 语音按钮条件渲染逻辑合理

语音按钮的条件渲染逻辑正确，仅在 allowSpeech 为真时显示。按钮布局合理，位于加载/发送按钮之前。

274-274: 组件导出更新完整

SpeechButton 已正确添加到自定义 actions 的组件列表中，确保用户可以在自定义渲染时使用该组件。

cloudflare-workers-and-pages · 2025-02-21T03:08:59Z

Deploying ant-design-x with Cloudflare Pages

Latest commit:	`601347a`
Status:	✅ Deploy successful!
Preview URL:	https://56b764ca.ant-design-x.pages.dev
Branch Preview URL:	https://fix-miss-speech.ant-design-x.pages.dev

View logs

github-actions · 2025-02-21T03:09:28Z

size-limit report 📦

Path	Size
`dist/antdx.min.js`	40.3 KB (-51 B 🔽)

cloudflare-workers-and-pages · 2025-02-21T03:36:37Z

Deploying ant-design-x with Cloudflare Pages

Latest commit:	`90ddf92`
Status:	⚡️ Build in progress...

View logs

cloudflare-workers-and-pages · 2025-02-21T03:39:41Z

Deploying ant-design-x with Cloudflare Pages

Latest commit:	`90ddf92`
Status:	✅ Deploy successful!
Preview URL:	https://8ca67df8.ant-design-x.pages.dev
Branch Preview URL:	https://fix-miss-speech.ant-design-x.pages.dev

View logs

codecov · 2025-02-21T03:41:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.79%. Comparing base (ba911ce) to head (90ddf92).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #549   +/-   ##
=======================================
  Coverage   91.79%   91.79%           
=======================================
  Files          67       67           
  Lines        1463     1463           
  Branches      385      386    +1     
=======================================
  Hits         1343     1343           
  Misses        120      120

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

addingtonbear · 2025-02-22T09:28:20Z

great work!

zombieJ added 2 commits February 21, 2025 11:03

fix: actions missing speech

82ac155

test: update snapshot

601347a

coderabbitai bot reviewed Feb 21, 2025

View reviewed changes

test: update snapshot

90ddf92

afc163 approved these changes Feb 21, 2025

View reviewed changes

YumoImer approved these changes Feb 21, 2025

View reviewed changes

zombieJ merged commit 511bb80 into main Feb 21, 2025
15 checks passed

zombieJ deleted the fix-miss-speech branch February 21, 2025 07:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Sender with `actions` missing SpeechButton #549

fix: Sender with `actions` missing SpeechButton #549

zombieJ commented Feb 21, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 21, 2025 •

edited

Loading

Review skipped

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Feb 21, 2025 •

edited

Loading

codecov bot commented Feb 21, 2025 •

edited

Loading

coderabbitai bot left a comment

cloudflare-workers-and-pages bot commented Feb 21, 2025

github-actions bot commented Feb 21, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 21, 2025

cloudflare-workers-and-pages bot commented Feb 21, 2025

codecov bot commented Feb 21, 2025 •

edited

Loading

addingtonbear commented Feb 22, 2025

fix: Sender with actions missing SpeechButton #549

fix: Sender with actions missing SpeechButton #549

Conversation

zombieJ commented Feb 21, 2025 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Feb 21, 2025 • edited Loading

Review skipped

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Feb 21, 2025 • edited Loading

codecov bot commented Feb 21, 2025 • edited Loading

Bundle Report

coderabbitai bot left a comment

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Feb 21, 2025

Deploying ant-design-x with Cloudflare Pages

github-actions bot commented Feb 21, 2025 • edited Loading

size-limit report 📦

cloudflare-workers-and-pages bot commented Feb 21, 2025

Deploying ant-design-x with Cloudflare Pages

cloudflare-workers-and-pages bot commented Feb 21, 2025

Deploying ant-design-x with Cloudflare Pages

codecov bot commented Feb 21, 2025 • edited Loading

Codecov Report

addingtonbear commented Feb 22, 2025

fix: Sender with `actions` missing SpeechButton #549

fix: Sender with `actions` missing SpeechButton #549

zombieJ commented Feb 21, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 21, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Feb 21, 2025 •

edited

Loading

codecov bot commented Feb 21, 2025 •

edited

Loading

github-actions bot commented Feb 21, 2025 •

edited

Loading

codecov bot commented Feb 21, 2025 •

edited

Loading