fix(forms): improve field error method type defs #16524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `getFieldError` and `getFieldsError` to return actual types, instead of very restrictive `Object` type (which should be avoided in general, in favour of `unknown`, `object`, or `Record` depending on actual use).
|
Deploy preview for ant-design ready! Built with commit 6119095 |
Codecov Report
@@ Coverage Diff @@
## master #16524 +/- ##
=======================================
Coverage 95.71% 95.71%
=======================================
Files 258 258
Lines 7120 7120
Branches 1970 1970
=======================================
Hits 6815 6815
Misses 303 303
Partials 2 2
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #16524 +/- ##
=======================================
Coverage 95.71% 95.71%
=======================================
Files 258 258
Lines 7120 7120
Branches 1970 1970
=======================================
Hits 6815 6815
Misses 303 303
Partials 2 2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
👻 What's the background?
getFieldErrorandgetFieldsError's return types are too restrictive, forcing consumers to cast the methods when using them.💡 Solution
Change
getFieldErrorandgetFieldsErrorto return actual types, instead of very restrictiveObjecttype (which should be avoided in general, in favour ofunknown,object, orRecorddepending on actual use).📝 Changelog
☑️ Self Check before Merge