Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(inputItem): add safe-area #3180

Merged
merged 2 commits into from
Apr 28, 2019
Merged

Conversation

zack24q
Copy link
Contributor

@zack24q zack24q commented Apr 18, 2019

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • [x Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

@ghost ghost assigned zack24q Apr 18, 2019
@ghost ghost added the In Progress label Apr 18, 2019
@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #3180 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3180   +/-   ##
=======================================
  Coverage   60.05%   60.05%           
=======================================
  Files          92       92           
  Lines        2278     2278           
  Branches      654      654           
=======================================
  Hits         1368     1368           
  Misses        901      901           
  Partials        9        9
Flag Coverage Δ
#web 60.05% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 869e8ad...711b269. Read the comment docs.

@ziluo
Copy link
Contributor

ziluo commented Apr 19, 2019

顺便理一下其他组件有没有类似问题,如ActionSheet之类的

@zack24q zack24q requested a review from doxiaodong April 28, 2019 03:16
@doxiaodong doxiaodong merged commit c65e1e6 into master Apr 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-input-item-iphonex-style branch April 28, 2019 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants