Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(InputItem): this.state.value undefined error #3044

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

zack24q
Copy link
Contributor

@zack24q zack24q commented Jan 8, 2019

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

@zack24q zack24q requested a review from ziluo January 8, 2019 02:04
@ghost ghost assigned zack24q Jan 8, 2019
@ghost ghost added the In Progress label Jan 8, 2019
@codecov
Copy link

codecov bot commented Jan 8, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@9df1930). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3044   +/-   ##
=========================================
  Coverage          ?   60.16%           
=========================================
  Files             ?       92           
  Lines             ?     2249           
  Branches          ?      646           
=========================================
  Hits              ?     1353           
  Misses            ?      887           
  Partials          ?        9
Flag Coverage Δ
#web 60.16% <100%> (?)
Impacted Files Coverage Δ
components/input-item/index.tsx 61.42% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9df1930...9891db9. Read the comment docs.

@doxiaodong
Copy link
Contributor

@doxiaodong doxiaodong merged commit 6110711 into master Feb 19, 2019
@zack24q zack24q deleted the fix-input-item-error branch April 18, 2019 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants