Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#3000 and Fix inputItem make Picker unable to click in Wechat with IOS12; #3017

Merged
merged 2 commits into from
Mar 20, 2019

Conversation

thewindsword
Copy link
Contributor

@thewindsword thewindsword commented Dec 28, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • fix while height over 100% input-item make picker can't touch in wechat with ios 12.

#3000 fix it;

repo: https://codesandbox.io/s/j2j44wxj95
device: ios12.1,iphoneXr/iphone 8p/iphone 6s
software: wechat 7.0.0

zh:
修复IOS12.1下微信6.7.4~7.0.0版本网页中:
当小键盘弹出收缩时,会导致body重新渲染,并且致使触摸层错位。
已提交repo:https://codesandbox.io/s/j2j44wxj95
重现步骤为(PS:Safari正常):

  1. 选中最下方input-item,输入任意字符;
  2. 在小键盘没有缩下去情况下点击picker组件;
  3. 点击Picker确认发现点击无效。
  4. 长按界面当出现选择光标时发现确认键与实际渲染位置不符。

This change is Reviewable

@thewindsword thewindsword changed the title Fix inputItem make Picker unable to click in Wechat with IOS12; Fix#3000 and Fix inputItem make Picker unable to click in Wechat with IOS12; Dec 29, 2018
@doxiaodong
Copy link
Contributor

textarea-item has the same issue. can u fix it.

@thewindsword
Copy link
Contributor Author

the same as search-bar, I'll fix it later ;)

@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

Merging #3017 into master will decrease coverage by 0.19%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3017     +/-   ##
=========================================
- Coverage    60.1%   59.91%   -0.2%     
=========================================
  Files          92       92             
  Lines        2246     2255      +9     
  Branches      643      646      +3     
=========================================
+ Hits         1350     1351      +1     
- Misses        887      895      +8     
  Partials        9        9
Flag Coverage Δ
#web 59.91% <11.11%> (-0.2%) ⬇️
Impacted Files Coverage Δ
components/textarea-item/index.tsx 40.4% <0%> (-1.27%) ⬇️
components/input-item/index.tsx 59.28% <0%> (-1.3%) ⬇️
components/search-bar/index.tsx 77.58% <33.33%> (-1.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9c0a82...17aabf4. Read the comment docs.

@doxiaodong
Copy link
Contributor

@ziluo 你也看一下吧

@likezero likezero added the 2.2.9 label Jan 5, 2019
@likezero likezero self-assigned this Mar 20, 2019
@likezero
Copy link
Contributor

没问题,可以合并掉。覆盖率可以后面单独补

@doxiaodong
Copy link
Contributor

ok

@doxiaodong doxiaodong merged commit 9359453 into ant-design:master Mar 20, 2019
@Estelle00
Copy link

Estelle00 commented May 5, 2019

这个逻辑不对吧 为什么必须要props.onBlur存在 才修复呢 还有没有判断是否为IOS设备啊

@thewindsword
Copy link
Contributor Author

thewindsword commented May 5, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants