Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: button with icon and inline (#2742) #2822

Merged
merged 1 commit into from
Sep 6, 2018
Merged

Conversation

zack24q
Copy link
Contributor

@zack24q zack24q commented Sep 4, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

@ghost ghost assigned zack24q Sep 4, 2018
@ghost ghost added the In Progress label Sep 4, 2018
@codecov
Copy link

codecov bot commented Sep 4, 2018

Codecov Report

Merging #2822 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2822   +/-   ##
=======================================
  Coverage   59.37%   59.37%           
=======================================
  Files          92       92           
  Lines        2208     2208           
  Branches      628      628           
=======================================
  Hits         1311     1311           
  Misses        891      891           
  Partials        6        6
Flag Coverage Δ
#web 59.37% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6134577...28fd490. Read the comment docs.

Copy link
Contributor

@doxiaodong doxiaodong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@doxiaodong doxiaodong merged commit 03f0bbe into master Sep 6, 2018
@zack24q zack24q deleted the fix-button-inline-icon branch September 6, 2018 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants