Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input-item: Add a clear button for android platform #2358

Merged
merged 5 commits into from
May 22, 2018

Conversation

alwaysloseall
Copy link
Contributor

@alwaysloseall alwaysloseall commented Feb 28, 2018

#2288
First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

@alwaysloseall alwaysloseall changed the title Input item clear android Add a delete button for android platform Feb 28, 2018
@alwaysloseall alwaysloseall changed the title Add a delete button for android platform Add a clear button for android platform Feb 28, 2018
@alwaysloseall alwaysloseall changed the title Add a clear button for android platform input-item: Add a clear button for android platform Feb 28, 2018
@paranoidjk
Copy link
Contributor

Does clean icon is a Android Design Guide or something? Why only add in android?

@paranoidjk
Copy link
Contributor

cc @silentcloud

@alwaysloseall
Copy link
Contributor Author

@paranoidjk the clean icon is gotten from antd-mobile`s assets image.only added in android, cuz ios already have a clear button in input-item

@codecov
Copy link

codecov bot commented May 22, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@4a71fbe). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2358   +/-   ##
=========================================
  Coverage          ?   56.82%           
=========================================
  Files             ?      144           
  Lines             ?     2439           
  Branches          ?      732           
=========================================
  Hits              ?     1386           
  Misses            ?     1048           
  Partials          ?        5
Flag Coverage Δ
#web 56.82% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a71fbe...16e2e48. Read the comment docs.

@ghost ghost assigned warmhug May 22, 2018
@ghost ghost added the In Progress label May 22, 2018
@warmhug warmhug merged commit 682dfa8 into ant-design:master May 22, 2018
@warmhug
Copy link
Contributor

warmhug commented May 22, 2018

close #2288

warmhug added a commit that referenced this pull request May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants