-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fixed bug in image-picker, Uncaught TypeError: Cannot set pro… #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perty 'value' of null
Codecov Report
@@ Coverage Diff @@
## master #2302 +/- ##
==========================================
- Coverage 57.63% 57.61% -0.03%
==========================================
Files 260 260
Lines 4464 4466 +2
Branches 1178 1179 +1
==========================================
Hits 2573 2573
- Misses 1890 1892 +2
Partials 1 1
Continue to review full report at Codecov.
|
BANG88
added a commit
to BANG88/ant-design-mobile
that referenced
this pull request
Feb 7, 2018
BANG88
added a commit
to BANG88/ant-design-mobile
that referenced
this pull request
Mar 10, 2018
BANG88
added a commit
to BANG88/ant-design-mobile
that referenced
this pull request
Mar 13, 2018
* master: fix(Carousel): ant-design#2369 chore: delete upgrade tip fix: Fix all failed test (ant-design#2337) fix: modal.alert content align=center (ant-design#2347) bugfix: fixed bug in image-picker, Uncaught TypeError: Cannot set property 'value' of null (ant-design#2302) # Conflicts: # components/_util/upgradeTip.tsx # components/image-picker/index.tsx
BANG88
added a commit
to BANG88/ant-design-mobile
that referenced
this pull request
Mar 15, 2018
* master: test: update snapshot ci: upgrade to nodejs 8 fix(Carousel): ant-design#2369 chore: delete upgrade tip fix: Fix all failed test (ant-design#2337) fix: modal.alert content align=center (ant-design#2347) bugfix: fixed bug in image-picker, Uncaught TypeError: Cannot set property 'value' of null (ant-design#2302) # Conflicts: # components/_util/upgradeTip.tsx # components/image-picker/index.tsx
paranoidjk
pushed a commit
that referenced
this pull request
Mar 16, 2018
* refactor(util): noImplicitAny * refactor(accordion): type definitions improvements * refactor(action-sheet): add missing type definitions * chore: configuration * refactor(activity-indicator): type definitions * chore: configuration * refactor(badge): type definitions * refactor(button): type definitions * refactor(calendar): type definitions * refactor(card): type definitions * refactor(carousel): add type definitions and refactor native part * refactor(checkbox): type definitions * refactor(list): type definitions * refactor(date-picker): type definitions * refactor(date-picker-view): type definitions * refactor(drawer): type definitions * refactor(flex): type definitions * refactor(grid): type definitions * refactor(icon): type definitions * refactor(image-picker): type definitions * refactor(input-item): type definitions and code refactor * refactor(locale-provider): type definitions * refactor(menu): type definitions * refactor(modal): type definitions * refactor(nav-bar): type definitions * refactor(notice-bar): type definitions * refactor(pagination): type definitions * refactor(picker): type definitions * refactor(picker-view): type definitions * refactor(popover): type definitions * refactor(progress): type definitions * refactor(radio): type definitions * refactor(range): type definitions * refactor(result): type definitions * refactor(search-bar): type definitions * refactor(segmented-control): type definitions * refactor(slider): type definitions * refactor(stepper): type definitions * refactor(steps): type definitions * refactor(swipe-action): type definitions * refactor(switch): type definitions * refactor(tab-bar): type definitions * refactor(tabs): type definitions * refactor(tag): type definitions * refactor(view|text): type definitions * refactor(textarea-item): type definitions * refactor(toast): type definitions * refactor(white-space): type definitions * refactor(wing-blank): type definitions * refactor(list-view): type definitions * refactor(demo): any * chore(style): use ant-tools tslint configurations * test: update snapshots * chore: remove unnecessary configurations and deps * chore: tslint * chore: add setup file * fix: #2302 * test: update snap * chore: update deps and fix tests * chore: try to let jest faster * refactor(Icon): extends from SVG Props
lixiaoyang1992
pushed a commit
to lixiaoyang1992/ant-design-mobile
that referenced
this pull request
Apr 26, 2018
…perty 'value' of null (ant-design#2302)
lixiaoyang1992
pushed a commit
to lixiaoyang1992/ant-design-mobile
that referenced
this pull request
Apr 26, 2018
* refactor(util): noImplicitAny * refactor(accordion): type definitions improvements * refactor(action-sheet): add missing type definitions * chore: configuration * refactor(activity-indicator): type definitions * chore: configuration * refactor(badge): type definitions * refactor(button): type definitions * refactor(calendar): type definitions * refactor(card): type definitions * refactor(carousel): add type definitions and refactor native part * refactor(checkbox): type definitions * refactor(list): type definitions * refactor(date-picker): type definitions * refactor(date-picker-view): type definitions * refactor(drawer): type definitions * refactor(flex): type definitions * refactor(grid): type definitions * refactor(icon): type definitions * refactor(image-picker): type definitions * refactor(input-item): type definitions and code refactor * refactor(locale-provider): type definitions * refactor(menu): type definitions * refactor(modal): type definitions * refactor(nav-bar): type definitions * refactor(notice-bar): type definitions * refactor(pagination): type definitions * refactor(picker): type definitions * refactor(picker-view): type definitions * refactor(popover): type definitions * refactor(progress): type definitions * refactor(radio): type definitions * refactor(range): type definitions * refactor(result): type definitions * refactor(search-bar): type definitions * refactor(segmented-control): type definitions * refactor(slider): type definitions * refactor(stepper): type definitions * refactor(steps): type definitions * refactor(swipe-action): type definitions * refactor(switch): type definitions * refactor(tab-bar): type definitions * refactor(tabs): type definitions * refactor(tag): type definitions * refactor(view|text): type definitions * refactor(textarea-item): type definitions * refactor(toast): type definitions * refactor(white-space): type definitions * refactor(wing-blank): type definitions * refactor(list-view): type definitions * refactor(demo): any * chore(style): use ant-tools tslint configurations * test: update snapshots * chore: remove unnecessary configurations and deps * chore: tslint * chore: add setup file * fix: ant-design#2302 * test: update snap * chore: update deps and fix tests * chore: try to let jest faster * refactor(Icon): extends from SVG Props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug in image-picker, Uncaught TypeError: Cannot set property 'value' of null.
When the selector at the header of a new row, then delete a pic, and readd a new pic, the bug appear. So, do not delete the fileselectorInput, if the input is null.
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
npm run lint
and fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :
This change is