Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image picker feature, add file accept #2269

Merged
merged 3 commits into from
Jan 29, 2018

Conversation

dqmmpb
Copy link
Contributor

@dqmmpb dqmmpb commented Jan 20, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

@dqmmpb dqmmpb changed the title Image picker feature Image picker featur, add file accept Jan 20, 2018
@dqmmpb dqmmpb changed the title Image picker featur, add file accept Image picker feature, add file accept Jan 20, 2018
@codecov
Copy link

codecov bot commented Jan 20, 2018

Codecov Report

Merging #2269 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2269   +/-   ##
=======================================
  Coverage   57.79%   57.79%           
=======================================
  Files         260      260           
  Lines        4459     4459           
  Branches     1178     1178           
=======================================
  Hits         2577     2577           
  Misses       1881     1881           
  Partials        1        1
Flag Coverage Δ
#rn 60.78% <ø> (ø) ⬆️
#web 55.23% <50%> (ø) ⬆️
Impacted Files Coverage Δ
components/image-picker/PropsType.tsx 0% <ø> (ø) ⬆️
components/image-picker/index.tsx 33.64% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b3de88...0a32c3e. Read the comment docs.

@paranoidjk paranoidjk added this to the 2.2.0 milestone Jan 22, 2018
@paranoidjk paranoidjk removed this from the 2.2.0 milestone Jan 29, 2018
@paranoidjk paranoidjk merged commit 8d8e675 into ant-design:master Jan 29, 2018
paranoidjk added a commit that referenced this pull request Jan 29, 2018
lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this pull request Apr 26, 2018
* add file accept in image-picker

* add file accept in image-picker

* add file accept in image-picker
lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this pull request Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants