Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(site): navigate to correct site for current language when searching component #1622

Merged
merged 1 commit into from
Jul 29, 2017

Conversation

marswong
Copy link
Contributor

@marswong marswong commented Jul 28, 2017

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

@mention-bot
Copy link

@marswong, thanks for your PR! By analyzing the history of the files in this pull request, we identified @warmhug, @liqi07 and @pingan1927 to be potential reviewers.

@codecov
Copy link

codecov bot commented Jul 28, 2017

Codecov Report

Merging #1622 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1622   +/-   ##
=======================================
  Coverage   66.16%   66.16%           
=======================================
  Files         228      228           
  Lines        4425     4425           
  Branches     1158     1158           
=======================================
  Hits         2928     2928           
  Misses       1496     1496           
  Partials        1        1
Flag Coverage Δ
#rn 65.59% <ø> (ø) ⬆️
#web 66.72% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31b565c...05da286. Read the comment docs.

@paranoidjk
Copy link
Contributor

@marswong Thanks for your PR.

Could you please do rebase master and clean you commit list, since there is another one's commit in your pr.

@marswong
Copy link
Contributor Author

@paranoidjk
Sorry, I have updated the commit history :)

@paranoidjk paranoidjk merged commit 78e4f8b into ant-design:master Jul 29, 2017
lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this pull request Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants