feat(Modal): support placeholder & add theme #1603
Conversation
|
@paranoidjk, thanks for your PR! By analyzing the history of the files in this pull request, we identified @silentcloud, @cncolder and @yiminghe to be potential reviewers. |
|
@silentcloud rn 忘记改了... 需要同步更新吗？ |
|
@paranoidjk 加一下吧，保持一致 |
| @@ -57,7 +57,7 @@ export default class Modal extends ModalComponent<ModalProps, any> { | |||
| buttonStyle = button.style; | |||
| if (typeof buttonStyle === 'string') { | |||
| const styleMap = { | |||
| cancel: { fontWeight: 'bold' }, | |||
There was a problem hiding this comment.
这里是视觉让去掉的么？cancel 这种 style 类型是和 rn 样式保持一致的 http://facebook.github.io/react-native/docs/alert.html
There was a problem hiding this comment.
是的，看的写的 gitlab # 469
Codecov Report
@@ Coverage Diff @@
## master #1603 +/- ##
==========================================
- Coverage 66.05% 65.37% -0.68%
==========================================
Files 228 106 -122
Lines 4431 2175 -2256
Branches 1165 609 -556
==========================================
- Hits 2927 1422 -1505
+ Misses 1503 753 -750
+ Partials 1 0 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1603 +/- ##
=========================================
+ Coverage 66.05% 66.2% +0.14%
=========================================
Files 228 228
Lines 4431 4421 -10
Branches 1165 1157 -8
=========================================
Hits 2927 2927
+ Misses 1503 1493 -10
Partials 1 1
Continue to review full report at Codecov.
|
components/modal/AlertContainer.tsx
Outdated
| @@ -56,7 +63,7 @@ export default class AlertContainer extends React.Component<AlertContainerProps, | |||
| onAnimationEnd={onAnimationEnd} | |||
| > | |||
| <ScrollView> | |||
| <Text>{content}</Text> | |||
| <Text style={styles.content}>{content}</Text> | |||
There was a problem hiding this comment.
@silentcloud 改 rn 的时候给这里加 style 就显示不出来了，也没有报错，inspector 也没有这一块，去掉 style 就好了。 啥原因？
* feat(Modal): support placeholder & add theme ref gitlab 469 * feat(Modal): rn style * fix: rn style * fix: interface * fix: lint
ref gitlab 469
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
npm run lintand fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :
This change is