Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-flex #1532 #1535

Merged
merged 1 commit into from
Jul 7, 2017
Merged

fix-flex #1532 #1535

merged 1 commit into from
Jul 7, 2017

Conversation

pingan1927
Copy link
Contributor

@pingan1927 pingan1927 commented Jul 6, 2017

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

@mention-bot
Copy link

@pingan1927, thanks for your PR! By analyzing the history of the files in this pull request, we identified @paranoidjk, @warmhug and @silentcloud to be potential reviewers.

@warmhug
Copy link
Contributor

warmhug commented Jul 6, 2017

就只改了文档、不改代码?

@paranoidjk
Copy link
Contributor

ref #1532

Api 是 break change,放 2.0 改,这里只是优化文档

@paranoidjk paranoidjk merged commit 9a9dc01 into master Jul 7, 2017
@paranoidjk paranoidjk deleted the fix-flex branch July 7, 2017 05:07
@pingan1927
Copy link
Contributor Author

API再单独改

pingan1927 added a commit that referenced this pull request Jul 10, 2017
pingan1927 added a commit that referenced this pull request Jul 10, 2017
lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this pull request Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants