add test for switch, ref #1274 #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@silentcloud, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yesmeck, @cncolder and @paranoidjk to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #1513 +/- ##
=======================================
Coverage 65.34% 65.34%
=======================================
Files 229 229
Lines 2271 2271
Branches 699 699
=======================================
Hits 1484 1484
Misses 786 786
Partials 1 1
Continue to review full report at Codecov.
|
paranoidjk
reviewed
Jun 30, 2017
| const onChange = jest.fn(); | ||
| const wrapper = shallow(<Switch checked onChange={onChange} />); | ||
| expect(wrapper.find('input').is('input[value="on"]')).toBeTruthy(); | ||
| // I don't know why click/change doesn't change the value to `off` |
There was a problem hiding this comment.
你这个测试用例测错了，checkbox 的 value 本来就不变的...
应该测 checked 这个 attribute
There was a problem hiding this comment.
至于 这个 value=on 我猜是 chrome 默认的？
There was a problem hiding this comment.
确认，是 react 的默认值，不是 chrome 的
lixiaoyang1992
pushed a commit
to lixiaoyang1992/ant-design-mobile
that referenced
this pull request
Apr 26, 2018
* add test for switch, ref ant-design#1274 * add issue url * fix: test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is