Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stepper translation, ref #329 #1286

Merged
merged 3 commits into from
May 10, 2017
Merged

stepper translation, ref #329 #1286

merged 3 commits into from
May 10, 2017

Conversation

silentcloud
Copy link
Contributor

@silentcloud silentcloud commented May 9, 2017

First of all, thanks for your contribution! :-)

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

This change is Reviewable

@silentcloud silentcloud force-pushed the translate-stepper branch from a431063 to 4b6752a Compare May 9, 2017 09:08
@codecov
Copy link

codecov bot commented May 9, 2017

Codecov Report

Merging #1286 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1286     +/-   ##
=========================================
+ Coverage   61.81%   61.92%   +0.1%     
=========================================
  Files         219      219             
  Lines        4154     4165     +11     
  Branches     1222     1226      +4     
=========================================
+ Hits         2568     2579     +11     
  Misses       1585     1585             
  Partials        1        1
Flag Coverage Δ
#rn 63.12% <ø> (ø) ⬆️
#web 60.69% <ø> (+0.21%) ⬆️
Impacted Files Coverage Δ
components/popover/index.web.tsx 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee84076...12bde28. Read the comment docs.

@@ -96,7 +96,7 @@ exports[`renders ./components/stepper/demo/basic.md correctly 1`] = `
<div
class="am-list-content"
>
显示数值(使用 MouseEvent, for PC)
Show number value(Use MouseEvent for PC by default)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里没有 by default

paranoidjk pushed a commit that referenced this pull request May 10, 2017
* stepper translation, ref #329

* remove typo

* update snapshot
@paranoidjk paranoidjk merged commit c07be13 into master May 10, 2017
@paranoidjk paranoidjk deleted the translate-stepper branch May 10, 2017 05:19
lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this pull request Apr 26, 2018
* stepper translation, ref ant-design#329

* remove typo

* update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants