Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix platform prop warning list item div #1276

Merged
merged 1 commit into from
May 8, 2017

Conversation

cncolder
Copy link
Contributor

@cncolder cncolder commented May 8, 2017

omit platform prop before pass to div

this pr close #1278

First of all, thanks for your contribution! :-)

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

This change is Reviewable

omit platform prop before pass to div
@mention-bot
Copy link

@cncolder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yiminghe, @pingan1927 and @warmhug to be potential reviewers.

@codecov
Copy link

codecov bot commented May 8, 2017

Codecov Report

Merging #1276 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1276      +/-   ##
==========================================
+ Coverage   61.94%   61.95%   +<.01%     
==========================================
  Files         219      219              
  Lines        4157     4158       +1     
  Branches     1226     1226              
==========================================
+ Hits         2575     2576       +1     
  Misses       1581     1581              
  Partials        1        1
Flag Coverage Δ
#rn 63.38% <ø> (ø) ⬆️
#web 60.48% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
components/list/ListItem.web.tsx 70.17% <ø> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3def10d...5eb1426. Read the comment docs.

@paranoidjk paranoidjk merged commit 0960bf5 into ant-design:master May 8, 2017
@paranoidjk
Copy link
Contributor

@cncolder 可以在commit message里写上 close #1278

lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this pull request Apr 26, 2018
omit platform prop before pass to div
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants