Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DatePicker): defaultDate should consider maxDate & minDate #1035

Merged
merged 1 commit into from
Mar 22, 2017

Conversation

paranoidjk
Copy link
Contributor

@paranoidjk paranoidjk commented Mar 22, 2017

fix #1033

First of all, thanks for your contribution! :-)

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

@mention-bot
Copy link

@paranoidjk, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yiminghe, @ottomao and @warmhug to be potential reviewers.

@codecov
Copy link

codecov bot commented Mar 22, 2017

Codecov Report

Merging #1035 into master will increase coverage by 0.01%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master    #1035      +/-   ##
==========================================
+ Coverage   69.13%   69.14%   +0.01%     
==========================================
  Files         215      215              
  Lines        3936     3947      +11     
  Branches     1177     1181       +4     
==========================================
+ Hits         2721     2729       +8     
- Misses       1213     1216       +3     
  Partials        2        2
Flag Coverage Δ
#rn 73.16% <80%> (+0.04%) ⬆️
#web 64.98% <100%> (-0.06%) ⬇️
Impacted Files Coverage Δ
components/date-picker/index.tsx 92.85% <100%> (-3.58%) ⬇️
components/date-picker/index.web.tsx 92.59% <100%> (-3.71%) ⬇️
components/date-picker/utils.tsx 84.61% <77.77%> (+4.61%) ⬆️
components/slider/index.tsx 85.71% <0%> (+3.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7664bd2...5557a08. Read the comment docs.

@paranoidjk paranoidjk merged commit 1cf0e56 into master Mar 22, 2017
@paranoidjk paranoidjk deleted the fix/1033 branch March 22, 2017 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DatePicker 组件,默认日期没设置在 minDate 和 maxDate 范围内
3 participants