Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkbox/radio 支持 children #499

Closed
yiminghe opened this issue Nov 9, 2016 · 6 comments
Closed

checkbox/radio 支持 children #499

yiminghe opened this issue Nov 9, 2016 · 6 comments
Assignees
Milestone

Comments

@yiminghe
Copy link
Contributor

yiminghe commented Nov 9, 2016

react-native & web

<checkbox>点击</checkbox>

相当于 html

<label><checkbox />点击</label>
@pingan1927
Copy link
Contributor

pingan1927 commented Nov 10, 2016

RcCheckbox本身不支持children。

<checkbox>点击</checkbox>

=>

<label><RcCheckbox />点击</label>

@silentcloud
Copy link
Contributor

@pingan1927 rn的我这边改好了,瞅哈 PR,没问题的话合了

@yiminghe web 的需要 rc-checkbox 支持

@afc163
Copy link
Member

afc163 commented Nov 10, 2016

https://github.com/ant-design/ant-design/blob/master/components/checkbox/index.tsx#L43

@yiminghe
Copy link
Contributor Author

@pingan1927 web

if(this.props.children){
 <label><RcCheckbox>
} else {
  <RcCheckbox>
}

@silentcloud
Copy link
Contributor

@warmhug 见上

warmhug added a commit that referenced this issue Nov 15, 2016
@yiminghe yiminghe added this to the next milestone Dec 1, 2016
@Liuqing650
Copy link

checkbox咱能不能给定义个方的?单选是圆的,复选还是,还不好修改

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants