Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hammerjs #1565

Closed
2 tasks done
paranoidjk opened this issue Jul 13, 2017 · 4 comments
Closed
2 tasks done

Remove hammerjs #1565

paranoidjk opened this issue Jul 13, 2017 · 4 comments
Assignees
@paranoidjk
Milestone
2.0.0

Comments

@paranoidjk
Copy link
Contributor

paranoidjk commented Jul 13, 2017 •
edited
Loading

we just need horizontal swipe ，but hammerjs gzip size is 7.34 kb.

cc @pingan1927 @warmhug @yiminghe @silentcloud
@paranoidjk paranoidjk self-assigned this Jul 13, 2017
@paranoidjk paranoidjk added this to the 2.0.0 milestone Jul 13, 2017
@cncolder
Copy link
Contributor

+1 hammer is too heavy.

@paranoidjk paranoidjk mentioned this issue Jul 19, 2017
Closed
@paranoidjk
Copy link
Contributor Author

Released rc-gesture@0.0.1, 目的是用少的代码支持Hammerjs的大部分功能 https://react-component.github.io/gesture/examples/simple.html

@paranoidjk
Copy link
Contributor Author

webpack 太可怕了，几百行代码 compile 之后竟然和几千行的 hammerjs 差不多大
https://unpkg.com/rc-gesture@0.0.2/ 插入了一堆模块的包裹代码

等待尝试三个方案：

  • 不再经 webpack 打包，用 rollup
  • webpack 3 scope hoisting
  • rc-gesture 本身按手势模块化，按需加载

@paranoidjk paranoidjk mentioned this issue Jul 25, 2017
Open
@paranoidjk
Copy link
Contributor Author

ref react-component/rc-tools#37

paranoidjk added a commit to react-component/gesture that referenced this issue Jul 25, 2017
@paranoidjk
chore: add dist scripts
6c9804a 
ant-design/ant-design-mobile#1565
@paranoidjk paranoidjk mentioned this issue Jul 31, 2017
Closed
33 tasks
@paranoidjk paranoidjk mentioned this issue Aug 28, 2017
Closed
lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this issue Apr 26, 2018
@paranoidjk @lixiaoyang1992
feat(SwipeAction): replace hammerjs with rc-gesture. close ant-design…
f874383 
…#1565
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paranoidjk paranoidjk

Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@cncolder @paranoidjk