Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for species transport model #2280

Merged
merged 7 commits into from
Nov 30, 2023
Merged

Conversation

ansjsia
Copy link
Collaborator

@ansjsia ansjsia commented Nov 27, 2023

Test the following features of the species transport model:

  • Turning on the species transport model
  • Checking the mixtures object command list
  • Creating a custom mixture with custom species (using the TUI)
  • Copying an existing mixture
  • Reassigning a cellzone material to a different mixture
  • Deleting an existing mixture

Currently, the species transport model cannot be used without resorting to TUI commands due to the following open issues with the settings API:

@ansjsia
Copy link
Collaborator Author

ansjsia commented Nov 28, 2023

@dnwillia-work @raph-luc For your consideration in the latest commit. I've renamed the file to test_species_model.py and split it up into multiple tests. I created a fixture such that only one solver instance would be used across all tests, ensuring that we only start and shut down Fluent once for all six tests.

The tests are:

  1. Activate the species transport model
  2. Check the command list
  3. Create a custom mixture from custom species
  4. Duplicate a mixture
  5. Change the mixture assigned to a cellzone
  6. Delete a mixture

The problem is that if one of these tests fails, all the following tests will fail as well, like dominoes. I'm not sure if this is acceptable. If it isn't, a potential solution is to implement recognizing an incremental test marker in our conftests.py file that would skip all remaining tests in the class if one fails: https://docs.pytest.org/en/latest/example/simple.html#incremental-testing-test-steps

@ansjsia ansjsia force-pushed the testing/species-transport branch from 755101b to e099256 Compare November 29, 2023 15:53
@ansjsia
Copy link
Collaborator Author

ansjsia commented Nov 29, 2023

@raph-luc @dnwillia-work I've recombined everything into one test in the latest commit. Hopefully the name and comments are sufficiently descriptive.

@ansjsia ansjsia enabled auto-merge (squash) November 29, 2023 19:40
@ansjsia
Copy link
Collaborator Author

ansjsia commented Nov 30, 2023

@dnwillia-work @raph-luc The unit testing check for 23R2 is stalling (timing out after 6 hours) consistently on the test test_meshing_workflow.py::test_watertight_workflow_children, which seems completely unrelated to this PR. It seems to fail when I run it locally on 23R2. Any insight?

@raph-luc
Copy link
Member

@ansjsia I believe it wasn't test_watertight_workflow_children that stalled (as the logs say that it passed, and it should pass if you try it locally as well), it was the test after that one: test_watertight_workflow_dynamic_interface.

The team is aware of these tests that have been randomly stalling, we aren't sure of what is going on yet.

I set the failed test to re-run, let's see if it hangs again or if it passes. Changes in main branch are set to skip this test, we can merge them here if it fails again

@ansjsia ansjsia merged commit 08e49ce into main Nov 30, 2023
@ansjsia ansjsia deleted the testing/species-transport branch November 30, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants