New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field data returns object #1538

Merged

prmukherj merged 48 commits into main from feat/field_data_returns_object

Apr 19, 2023

Collaborator

prmukherj commented Apr 12, 2023 •

edited by seanpearsonuk

Loading

FieldData modules like: "get_scalar_field_data", "get_surface_data", "get_vector_field_data" and "get_pathlines_field_data" to return objects instead of dictionaries.

Example Use Case:

>>> abs_press_data = field_data.get_scalar_field_data(field_name="absolute-pressure", surface_name="cold-inlet")
>>> abs_press_data.size
>>> abs_press_data[120].scalar_data

>>> velocity_vector_data = field_data.get_vector_field_data(field_name="velocity", surface_name="cold-inlet")
>>> velocity_vector_data.size
>>> velocity_vector_data.scale

>>> vertices_data = field_data.get_surface_data(data_type=SurfaceDataType.Vertices, surface_name="cold-inlet")
>>> vertices_data[5].x

>>> path_lines_data = field_data.get_pathlines_field_data(field_name="velocity", surface_name="cold-inlet")
>>> path_lines_data["lines"][100].node_count
>>> path_lines_data["lines"][100].node_data

Your Name added 2 commits

April 12, 2023 12:20


          Field data return objects.

ad9a0f6


          Add tests.

6be81ec

prmukherj requested review from seanpearsonuk and ajain-work

April 12, 2023 06:52


          Updated Faces Connectivity.

e037fb0

Collaborator

seanpearsonuk commented Apr 12, 2023

@prmukherj, Please could you provide a PR description. Thanks.

Your Name added 5 commits

April 12, 2023 14:42


          Update pytest marker.

7d153b3


          Renamed Common Properties


          node -> node_count

b229c9b


          Restructuring.

853b0c4


          Restructuring

a080843

prmukherj marked this pull request as ready for review

April 13, 2023 10:31

prmukherj requested review from mkundu1, dnwillia-work, hpohekar, alikasim72 and h-krishnan as code owners

April 13, 2023 10:31

seanpearsonuk reviewed

View reviewed changes

src/ansys/fluent/core/services/field_data.py Outdated Show resolved Hide resolved

Your Name added 2 commits

April 13, 2023 17:07


          Merge branch 'main' of https://github.com/pyansys/pyfluent into feat/…

e9341a0

…field_data_returns_object

Merged changes from main branch.


          List comprehension.

667c24d

seanpearsonuk reviewed

View reviewed changes

src/ansys/fluent/core/services/field_data.py Outdated Show resolved Hide resolved

seanpearsonuk reviewed

View reviewed changes

src/ansys/fluent/core/services/field_data.py Show resolved Hide resolved

seanpearsonuk reviewed

View reviewed changes

src/ansys/fluent/core/services/field_data.py Outdated Show resolved Hide resolved

seanpearsonuk reviewed

View reviewed changes

src/ansys/fluent/core/services/field_data.py Outdated Show resolved Hide resolved

seanpearsonuk reviewed

View reviewed changes

src/ansys/fluent/core/services/field_data.py Outdated Show resolved Hide resolved

seanpearsonuk reviewed

View reviewed changes

src/ansys/fluent/core/services/field_data.py Outdated Show resolved Hide resolved

seanpearsonuk reviewed

View reviewed changes

src/ansys/fluent/core/services/field_data.py Show resolved Hide resolved

Your Name added 2 commits

April 13, 2023 18:25


          Renaming.

8aca51e


          Added docstrings.

ac4fff1

ajain-work reviewed

View reviewed changes

src/ansys/fluent/core/services/field_data.py Outdated Show resolved Hide resolved

Your Name and others added 3 commits

April 17, 2023 19:36


          Updated field_data doc.

a321dcf


          Update doc style.

f4a9150


          Merge branch 'main' into feat/field_data_returns_object

cebd3d6

PipKat reviewed

View reviewed changes

doc/source/api/solver/fielddata.rst Outdated Show resolved Hide resolved

PipKat reviewed

View reviewed changes

doc/source/api/solver/fielddata.rst Outdated Show resolved Hide resolved

PipKat reviewed

View reviewed changes

doc/source/api/solver/fielddata.rst Outdated Show resolved Hide resolved

PipKat reviewed

View reviewed changes

src/ansys/fluent/core/services/field_data.py Outdated Show resolved Hide resolved

PipKat reviewed

View reviewed changes

src/ansys/fluent/core/services/field_data.py Outdated Show resolved Hide resolved

PipKat reviewed

View reviewed changes

src/ansys/fluent/core/services/field_data.py Outdated Show resolved Hide resolved

PipKat reviewed

View reviewed changes

src/ansys/fluent/core/services/field_data.py Outdated Show resolved Hide resolved

PipKat reviewed

View reviewed changes

src/ansys/fluent/core/services/field_data.py Outdated Show resolved Hide resolved

PipKat reviewed

View reviewed changes

src/ansys/fluent/core/services/field_data.py Outdated Show resolved Hide resolved

mkundu1 approved these changes

View reviewed changes

prmukherj and others added 8 commits

April 17, 2023 21:23


          Update doc/source/api/solver/fielddata.rst

32a39a2

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>


          Update src/ansys/fluent/core/services/field_data.py

0cbafe6

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>


          Update src/ansys/fluent/core/services/field_data.py

d540d09

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>


          Update src/ansys/fluent/core/services/field_data.py

b07b973

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>


          Update src/ansys/fluent/core/services/field_data.py

e5a8c35

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>


          Update src/ansys/fluent/core/services/field_data.py

5adc737

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>


          Update doc/source/api/solver/fielddata.rst

d2df9d3

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>


          Update doc/source/api/solver/fielddata.rst

0af1bf1

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>

hpohekar approved these changes

View reviewed changes


          Re-format docstring.

c1c9320

ajain-work reviewed

View reviewed changes

doc/source/api/solver/fielddata.rst Show resolved Hide resolved

ajain-work reviewed

View reviewed changes

doc/source/api/solver/fielddata.rst Outdated Show resolved Hide resolved

Your Name and others added 3 commits

April 18, 2023 09:40


          node_data -> node_indices

34a32b5


          Revert test fixes.

322a97b


          Merge branch 'main' into feat/field_data_returns_object

94ef058

prmukherj merged commit 6a2959d into main

prmukherj deleted the feat/field_data_returns_object branch

April 19, 2023 04:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

PipKat PipKat left review comments

seanpearsonuk seanpearsonuk left review comments

ajain-work ajain-work approved these changes

mkundu1 mkundu1 approved these changes

hpohekar hpohekar approved these changes

dnwillia-work Awaiting requested review from dnwillia-work

alikasim72 Awaiting requested review from alikasim72

h-krishnan Awaiting requested review from h-krishnan

Labels

None yet