Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid the usage of attrs 24.3.0 (temporary) #466

Merged
merged 11 commits into from
Jan 28, 2025
Merged

fix: avoid the usage of attrs 24.3.0 (temporary) #466

merged 11 commits into from
Jan 28, 2025

Conversation

clatapie
Copy link
Collaborator

This PR aims to fix the CICD.

@ansys-reviewer-bot
Copy link

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added documentation Improvements or additions to documentation maintenance Package and maintenance related bug Something isn't working labels Jan 28, 2025
@clatapie clatapie changed the title fix: cicd with semver update fix: avoid the usage of attrs 24.3.0 (temporary) Jan 28, 2025
@clatapie clatapie self-assigned this Jan 28, 2025
@clatapie clatapie requested a review from RobPasMue January 28, 2025 14:33
RobPasMue
RobPasMue approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but it seems that CI/CD is having a hard time running the docs. Want me to look into it?

@clatapie
Copy link
Collaborator Author

Thanks @RobPasMue!
I think the issue is the same one I ran into with PyMAPDL-Examples. I made a modification in the CICD, let's see whether it fixes the error or not.

@RobPasMue
Copy link
Member

I meant to only substitute it whenever you are using the MAPDL docker image. Otherwise it's not necessary 😄

RobPasMue
RobPasMue reviewed Jan 28, 2025
View reviewed changes
.github/workflows/ci_cd.yml Outdated Show resolved Hide resolved
.github/workflows/ci_cd.yml Outdated Show resolved Hide resolved
.github/workflows/ci_cd.yml Outdated Show resolved Hide resolved
.github/workflows/ci_cd.yml Outdated Show resolved Hide resolved
.github/workflows/ci_cd.yml Outdated Show resolved Hide resolved
.github/workflows/ci_cd.yml Outdated Show resolved Hide resolved
.github/workflows/ci_cd.yml Outdated Show resolved Hide resolved
.github/workflows/ci_cd.yml Outdated Show resolved Hide resolved
.github/workflows/ci_cd.yml Outdated Show resolved Hide resolved
.github/workflows/ci_cd.yml Outdated Show resolved Hide resolved
@clatapie @RobPasMue
Apply suggestions from code review
2f90e09 
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
@clatapie clatapie merged commit 35e8c56 into main Jan 28, 2025
28 checks passed
@clatapie clatapie deleted the fix/cicd branch January 28, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees

@clatapie clatapie

Labels
bug Something isn't working documentation Improvements or additions to documentation maintenance Package and maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clatapie @RobPasMue @pyansys-ci-bot