-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maint: updating cicd and start_mapdl
files
#223
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
==========================================
+ Coverage 85.61% 92.63% +7.02%
==========================================
Files 2 2
Lines 584 584
==========================================
+ Hits 500 541 +41
+ Misses 84 43 -41 |
As I mentioned in ansys/pymapdl-examples#178 it is an issue inside the container When running in PyMAPDL (if I am not mistaken) - you run things inside the container directly and you install these libraries inside it as well. However, here, you are connecting to it. So whenever you perform the install, it is not being installed for the container AFAICT. |
The container hasn't changed in ages (9 months)... why now it is asking for a new library to run? It does not make sense... |
Opting for avoiding the issue all together.... Let's use the new docker images (do not have this issue). Hence we won't be testing for versions older than v23.1 |
Fixed, images are being pulled and launched properly. I would apply the same changes to There are some tests not passing properly. I leave it up to you @clatapie |
The unit test Output for version 23.2:
Output for version 24.1:
The number of digits after the decimal point increased from 1 (for |
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Ready to merge? |
As title says.