Nets and Primitives Refactoring #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now Primitives and Nets from EDB are casted into a new data object. They both inherit the original EDB object so the functionalities and back compatibility is preserved.
Now Primitives and Nets from EDB are casted into a new data object. They both inherit the original EDB object so the functionalities and back compatibility is preserved.
…Enhancement/PlotEDBRemote
Alberto-DM
approved these changes
Dec 28, 2021
| try: | ||
| return getattr(self, key) | ||
| except: | ||
| raise AttributeError("Attribute not present") |
There was a problem hiding this comment.
When is it going in this except considering the if at line 33?
There was a problem hiding this comment.
when you pass a wrong argument
MaxJPRey
reviewed
Dec 28, 2021
pyaedt/edb_core/EDB_Data.py
Outdated
Comment on lines
45
to
55
| # def __setattr__(self, key, value): | ||
| # if key in dir(self): | ||
| # try: | ||
| # return setattr(self, key, value) | ||
| # except: | ||
| # raise AttributeError("Attribute not present") | ||
| # else: | ||
| # try: | ||
| # return setattr(self.rimitive, key, value) | ||
| # except: | ||
| # raise AttributeError("Attribute not present") |
There was a problem hiding this comment.
@maxcapodi78 Can it be deleted or otherwise remove the comments?
MaxJPRey
reviewed
Dec 28, 2021
pyaedt/edb_core/layout.py
Outdated
| @@ -92,7 +93,8 @@ def update_primitives(self): | |||
| layoutObjectInstances = layoutInstance.GetAllLayoutObjInstances() | |||
| for el in layoutObjectInstances.Items: | |||
| try: | |||
| self._prims.append(el.GetLayoutObj()) | |||
| # self._prims.append(el.GetLayoutObj()) | |||
There was a problem hiding this comment.
Suggested change
| # self._prims.append(el.GetLayoutObj()) |
MaxJPRey
reviewed
Dec 28, 2021
pyaedt/edb_core/EDB_Data.py
Outdated
| ------- | ||
| bool | ||
| """ | ||
| return not point.IsArc() |
There was a problem hiding this comment.
Should it be:
Suggested change
| return not point.IsArc() | |
| return point.IsArc() |
It is surprising to have the not. Maybe the IsArc() implementation is not intuitive.
MaxJPRey
reviewed
Dec 28, 2021
| ---------- | ||
| arc_segments : int | ||
| Number of facets to convert an arc. Default is `6`. | ||
|
|
MaxJPRey
reviewed
Dec 28, 2021
pyaedt/edb_core/EDB_Data.py
Outdated
|
|
||
| def _get_points_for_plot(self, my_net_points, num): | ||
| """ | ||
| Get the points to be plot |
There was a problem hiding this comment.
Suggested change
| Get the points to be plot | |
| Get the points to be plotted. |
MaxJPRey
reviewed
Dec 28, 2021
pyaedt/edb_core/EDB_Data.py
Outdated
| Returns | ||
| ------- | ||
| list | ||
| points generated along the arc. |
There was a problem hiding this comment.
Suggested change
| points generated along the arc. | |
| Points generated along the arc. |
MaxJPRey
reviewed
Dec 28, 2021
pyaedt/edb_core/EDB_Data.py
Outdated
|
|
||
| Returns | ||
| ------- | ||
| list |
There was a problem hiding this comment.
@maxcapodi78 I think that it returns 2 lists.
MaxJPRey
reviewed
Dec 28, 2021
pyaedt/edb_core/EDB_Data.py
Outdated
| y = [] | ||
| for i, point in enumerate(my_net_points): | ||
| # point = my_net_points[i] | ||
| if not point.IsArc(): |
There was a problem hiding this comment.
You can use the is_arc property (defined below) here.
MaxJPRey
approved these changes
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now Primitives and Nets from EDB are casted into a new data object. They both inherit the original EDB object so the functionalities and back compatibility is preserved.