Fix/solution type #615
Merged
Fix/solution type #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
MaxJPRey
approved these changes
Dec 1, 2021
|
Still seeing issues with 22.1. Taking it offline with @maxcapodi78 |
|
If you are seeing the tests Pass, then please merge it and then I will test after it has merged. There are certanly some places where the default version number can be extracted from 1 place. I see a few places where the version number is being got from different locations |
kbhagat-ansys
approved these changes
Dec 1, 2021
|
I was able to get IronPython unit test passing in 22.1 but I had to change the version in 2 places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.