REFACTOR: Add schematics Page option on create_gnd/create_wire #5712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
For more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5712 +/- ##
==========================================
+ Coverage 81.38% 85.19% +3.81%
==========================================
Files 155 156 +1
Lines 60819 61103 +284
==========================================
+ Hits 49499 52059 +2560
+ Misses 11320 9044 -2276 |
Samuelopez-ansys
approved these changes
Jan 31, 2025
|
@jvela018 Is this related to any issue? If not, please assign one to this PR, we are trying to map 1:1 Issues and PRs |
This was referenced Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables the creation of more complex circuit topologies. Namely, using multiple schematics pages. create_component already enabled this, but the wire and gnd components wouldn't enable new pages as it was fixed to page 1.