-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Conformal waveport extension bug fix #5688
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5688 +/- ##
==========================================
- Coverage 85.24% 85.23% -0.01%
==========================================
Files 154 154
Lines 60767 60754 -13
==========================================
- Hits 51802 51785 -17
- Misses 8965 8969 +4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem to make sense, can you have a look at my minor comments ?
src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py
Outdated
Show resolved
Hide resolved
src/ansys/aedt/core/workflows/hfss3dlayout/generate_arbitrary_wave_ports.py
Outdated
Show resolved
Hide resolved
…wave_ports.py Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
…wave_ports.py Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
For more information, see https://pre-commit.ci
Modification performed
Description
Fixing bug in extension.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist