Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Conformal waveport extension bug fix #5688

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

svandenb-dev
Copy link
Collaborator

@svandenb-dev svandenb-dev commented Jan 23, 2025

Description

Fixing bug in extension.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.23%. Comparing base (8c592a1) to head (87276c4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5688      +/-   ##
==========================================
- Coverage   85.24%   85.23%   -0.01%     
==========================================
  Files         154      154              
  Lines       60767    60754      -13     
==========================================
- Hits        51802    51785      -17     
- Misses       8965     8969       +4     

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem to make sense, can you have a look at my minor comments ?

svandenb-dev and others added 3 commits January 24, 2025 09:30
…wave_ports.py

Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
…wave_ports.py

Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) January 27, 2025 13:56
@Samuelopez-ansys Samuelopez-ansys dismissed SMoraisAnsys’s stale review January 27, 2025 13:56

Modification performed

@Samuelopez-ansys Samuelopez-ansys merged commit 73726c9 into main Jan 27, 2025
43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the arbitrary_wave_port_extension_bug_fix branch January 27, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants