Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: ISAR plot #5639

Merged
merged 30 commits into from
Jan 9, 2025
Merged

FEAT: ISAR plot #5639

merged 30 commits into from
Jan 9, 2025

Conversation

Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Jan 8, 2025

Description

Improve ISAR RCS plot

Issue linked

Close #5641

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement New features or code improvements label Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 72.22222% with 20 lines in your changes missing coverage. Please review.

Project coverage is 85.24%. Comparing base (59e48a4) to head (98d0e33).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5639      +/-   ##
==========================================
+ Coverage   81.38%   85.24%   +3.86%     
==========================================
  Files         152      152              
  Lines       60952    61008      +56     
==========================================
+ Hits        49606    52007    +2401     
+ Misses      11346     9001    -2345     

@Samuelopez-ansys Samuelopez-ansys marked this pull request as ready for review January 8, 2025 14:13
Samuelopez-ansys and others added 2 commits January 9, 2025 08:53
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this changes look good to me, thanks for the feature @Samuelopez-ansys

None the less, I would like to discuss two points:

  1. Should we use casefold() here instead of lower() ? I discovered this method in FIX: Fixes to get_object_material_properties method #5626 and it seems to be designed specifically for case-insensitive comparisons. This would allow users use special cases in certain languages or alphabets. However, we might not want to allow that :D
  2. Instead of adding a new file to the pyaedt repo, and since the JSON data is tiny, could we avoid adding the JSON file and create it on the fly while testing ? For example, at the begining of the file we could have a constant with the JSON file content and in the test's setup, we could create the file with json.dumps(...) ?

I marked this review as request changes but it's more to ensure that a discussion occurs than a real need for changes :)

Samuelopez-ansys and others added 6 commits January 9, 2025 10:34
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
@Samuelopez-ansys
Copy link
Member Author

@SMoraisAnsys I applied the casefold, I like it, and also I removed the JSON files in the test, and it creates them on the fly

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) January 9, 2025 11:15
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice to discover the use of the object request in pytest !

@Samuelopez-ansys Samuelopez-ansys merged commit ccd0937 into main Jan 9, 2025
42 of 43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the feat/isar_plot branch January 9, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve ISAR RCS plot
4 participants