Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Move onetwork_data_explorer to AedtObjects #5638

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Jan 8, 2025

Description

Move onetwork_data_explorer to general AEDT objects instead of initializing it on every application.

Issue linked

Close #5637

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) January 8, 2025 10:13
@github-actions github-actions bot added the bug Something isn't working label Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.28%. Comparing base (a457727) to head (58ecdff).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5638   +/-   ##
=======================================
  Coverage   85.27%   85.28%           
=======================================
  Files         152      152           
  Lines       60990    60993    +3     
=======================================
+ Hits        52011    52017    +6     
+ Misses       8979     8976    -3     

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Samuelopez-ansys Samuelopez-ansys merged commit 9754999 into main Jan 9, 2025
43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/issue_5637 branch January 9, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move network data explorer to AEDT Object level
2 participants