Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: Add possibility to specify python venv directory #5633

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

hui-zhou-a
Copy link
Contributor

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@hui-zhou-a
Copy link
Contributor Author

@Samuelopez-ansys I made minor change in the installer file. Just to make it possible to specify python venv directory. Please share your thought.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.26%. Comparing base (a457727) to head (aa76e18).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5633      +/-   ##
==========================================
- Coverage   85.27%   85.26%   -0.02%     
==========================================
  Files         152      152              
  Lines       60990    60937      -53     
==========================================
- Hits        52011    51959      -52     
+ Misses       8979     8978       -1     

@Samuelopez-ansys
Copy link
Member

@hui-zhou-a I think the VENV_DIR should include also the python_version, what I mean is that now VENV_DIR is just e:\venv

But if you analyze the code, the script will try to access something like:

e:\venv\310\Scripts

Which is not correct, because if the user pass a custom venv, I think the path passed will be directly e:\venv\310, also considering that if you create the venv manually, very likely the 310 will not exist.

@Samuelopez-ansys Samuelopez-ansys merged commit 59e48a4 into main Jan 9, 2025
43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the refactor-pyaedt_installer branch January 9, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants