-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR: Add possibility to specify python venv directory #5633
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
@Samuelopez-ansys I made minor change in the installer file. Just to make it possible to specify python venv directory. Please share your thought. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5633 +/- ##
==========================================
- Coverage 85.27% 85.26% -0.02%
==========================================
Files 152 152
Lines 60990 60937 -53
==========================================
- Hits 52011 51959 -52
+ Misses 8979 8978 -1 |
@hui-zhou-a I think the VENV_DIR should include also the python_version, what I mean is that now VENV_DIR is just e:\venv But if you analyze the code, the script will try to access something like: e:\venv\310\Scripts Which is not correct, because if the user pass a custom venv, I think the path passed will be directly e:\venv\310, also considering that if you create the venv manually, very likely the 310 will not exist. |
Description
Please provide a brief description of the changes made in this pull request.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist