Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Improve Icepak tests #5624

Merged
merged 17 commits into from
Jan 31, 2025
Merged

TEST: Improve Icepak tests #5624

merged 17 commits into from
Jan 31, 2025

Conversation

lorenzovecchietti
Copy link
Contributor

Close #5621

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@lorenzovecchietti lorenzovecchietti marked this pull request as draft January 3, 2025 18:10
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 85.16%. Comparing base (2b15ad5) to head (0c04761).
Report is 3 commits behind head on main.

❌ Your patch status has failed because the patch coverage (80.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5624      +/-   ##
==========================================
+ Coverage   81.40%   85.16%   +3.75%     
==========================================
  Files         155      155              
  Lines       60833    60838       +5     
==========================================
+ Hits        49521    51812    +2291     
+ Misses      11312     9026    -2286     

@lorenzovecchietti lorenzovecchietti changed the title Improve Icepak tests TEST: Improve Icepak tests Jan 7, 2025
@lorenzovecchietti lorenzovecchietti marked this pull request as ready for review January 8, 2025 09:26
@lorenzovecchietti lorenzovecchietti marked this pull request as draft January 8, 2025 10:43
@lorenzovecchietti lorenzovecchietti marked this pull request as ready for review January 31, 2025 09:32
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@Samuelopez-ansys Samuelopez-ansys merged commit 380c923 into main Jan 31, 2025
42 of 43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the icepak_tests branch January 31, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Icepak tests
2 participants