Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: via clustering extension #5592

Merged
merged 17 commits into from
Jan 27, 2025
Merged

Conversation

svandenb-dev
Copy link
Collaborator

@svandenb-dev svandenb-dev commented Dec 18, 2024

Description

New HFSS 3D layout extension managing via clustering. It interacts both with AEDT and PyEDB.
After opening the UI the tool creates a specific layer where the users can draw polygons and rectangle to select areas where via have to be merged. Once processed in EDB the new project is open in AEDT.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.
closing #5593

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@svandenb-dev svandenb-dev linked an issue Dec 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.25%. Comparing base (8c592a1) to head (c67e05c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5592   +/-   ##
=======================================
  Coverage   85.24%   85.25%           
=======================================
  Files         154      155    +1     
  Lines       60767    60807   +40     
=======================================
+ Hits        51802    51839   +37     
- Misses       8965     8968    +3     

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't tried the extension yet as it is not usable through AEDT.
Could you please extend toolkits_catalog.toml file to make it available ?

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) January 9, 2025 13:44
@Samuelopez-ansys
Copy link
Member

Hi @svandenb-dev , you missed adding the unit test.

@Samuelopez-ansys Samuelopez-ansys dismissed SMoraisAnsys’s stale review January 27, 2025 14:00

Modifications performed

@Samuelopez-ansys Samuelopez-ansys merged commit 6cd5947 into main Jan 27, 2025
43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the merge-clustering-extension branch January 27, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Via cluster extension
3 participants